HDA probe failure is observed on Tegra194 based platforms and this
happens due to reset failure. This series fixes the problem by
skipping the failing reset and DT bindings are updated accordingly.
Changelog
=========
v1 -> v2:
---------
* Updated HDA driver patch to skip the failing reset instead of
skipping resets in general for BPMP devices as per comment from
Dmitry.
* Used a better strucure name for SoC data as per comment from
Thierry.
* Dropped 'Fixes' tag in binding doc patch as per comment from
Dmitry.
Sameer Pujar (3):
ALSA: hda/tegra: Fix Tegra194 HDA reset failure
dt-bindings: sound: tegra: Update HDA resets
arm64: tegra: Remove non existent Tegra194 reset
.../bindings/sound/nvidia,tegra30-hda.yaml | 13 ++-
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 +-
sound/pci/hda/hda_tegra.c | 96 +++++++++++++++++++---
3 files changed, 97 insertions(+), 17 deletions(-)
--
2.7.4
Tegra194 does not really have "hda2codec_2x" related reset. Hence drop
this entry to reflect actual HW.
Fixes: 4878cc0c9fab ("arm64: tegra: Add HDA controller on Tegra194")
Signed-off-by: Sameer Pujar <[email protected]>
---
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
index 8d29b7f..6a1d896 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
@@ -976,9 +976,8 @@
<&bpmp TEGRA194_CLK_HDA2CODEC_2X>;
clock-names = "hda", "hda2hdmi", "hda2codec_2x";
resets = <&bpmp TEGRA194_RESET_HDA>,
- <&bpmp TEGRA194_RESET_HDA2HDMICODEC>,
- <&bpmp TEGRA194_RESET_HDA2CODEC_2X>;
- reset-names = "hda", "hda2hdmi", "hda2codec_2x";
+ <&bpmp TEGRA194_RESET_HDA2HDMICODEC>;
+ reset-names = "hda", "hda2hdmi";
power-domains = <&bpmp TEGRA194_POWER_DOMAIN_DISP>;
interconnects = <&mc TEGRA194_MEMORY_CLIENT_HDAR &emc>,
<&mc TEGRA194_MEMORY_CLIENT_HDAW &emc>;
--
2.7.4
Tegra194 HDA has only two resets unlike the previous generations of
Tegra SoCs. Hence update the reset list accordingly.
Signed-off-by: Sameer Pujar <[email protected]>
Acked-by: Thierry Reding <[email protected]>
---
.../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
index b55775e..70dbdff5 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
@@ -50,13 +50,18 @@ properties:
- const: hda2codec_2x
resets:
+ minItems: 2
maxItems: 3
reset-names:
- items:
- - const: hda
- - const: hda2hdmi
- - const: hda2codec_2x
+ oneOf:
+ - items:
+ - const: hda
+ - const: hda2hdmi
+ - const: hda2codec_2x
+ - items:
+ - const: hda
+ - const: hda2hdmi
power-domains:
maxItems: 1
--
2.7.4