2021-12-17 22:14:13

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] powerpc: dts: Remove "spidev" nodes

"spidev" is not a real device, but a Linux implementation detail. It has
never been documented either. The kernel has WARNed on the use of it for
over 6 years. Time to remove its usage from the tree.

Cc: Mark Brown <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
arch/powerpc/boot/dts/digsy_mtc.dts | 8 --------
arch/powerpc/boot/dts/o2d.dtsi | 6 ------
2 files changed, 14 deletions(-)

diff --git a/arch/powerpc/boot/dts/digsy_mtc.dts b/arch/powerpc/boot/dts/digsy_mtc.dts
index 57024a4c1e7d..dfaf974c0ce6 100644
--- a/arch/powerpc/boot/dts/digsy_mtc.dts
+++ b/arch/powerpc/boot/dts/digsy_mtc.dts
@@ -25,14 +25,6 @@ rtc@800 {
status = "disabled";
};

- spi@f00 {
- msp430@0 {
- compatible = "spidev";
- spi-max-frequency = <32000>;
- reg = <0>;
- };
- };
-
psc@2000 { // PSC1
status = "disabled";
};
diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
index b55a9e5bd828..7e52509fa506 100644
--- a/arch/powerpc/boot/dts/o2d.dtsi
+++ b/arch/powerpc/boot/dts/o2d.dtsi
@@ -34,12 +34,6 @@ psc@2000 { // PSC1
#address-cells = <1>;
#size-cells = <0>;
cell-index = <0>;
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <250000>;
- reg = <0>;
- };
};

psc@2200 { // PSC2
--
2.32.0



2021-12-20 12:31:22

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] powerpc: dts: Remove "spidev" nodes

On Fri, Dec 17, 2021 at 04:14:00PM -0600, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.

Reviwed-by: Mark Brown <[email protected]>

Thanks for cleaning these up.


Attachments:
(No filename) (343.00 B)
signature.asc (488.00 B)
Download all attachments

2021-12-26 21:54:15

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc: dts: Remove "spidev" nodes

On Fri, 17 Dec 2021 16:14:00 -0600, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
>

Applied to powerpc/next.

[1/1] powerpc: dts: Remove "spidev" nodes
https://git.kernel.org/powerpc/c/9cbbe6bae938dd335a5092b0ce41f88cb39ba40c

cheers