2022-01-07 00:52:37

by Yang Li

Subject: [PATCH -next] block: fix old-style declaration

Move the 'inline' keyword to the front of 'void'.

Remove a warning found by clang(make W=1 LLVM=1)
./include/linux/blk-mq.h:259:1: warning: ‘inline’ is not at beginning of
declaration

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
include/linux/blk-mq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index f40a05ecca4a..d319ffa59354 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -256,7 +256,7 @@ static inline unsigned short req_get_ioprio(struct request *req)
* @rq: The request to move
* @prev: The request preceding @rq in @src (NULL if @rq is the head)
*/
-static void inline rq_list_move(struct request **src, struct request **dst,
+static inline void rq_list_move(struct request **src, struct request **dst,
struct request *rq, struct request *prev)
{
if (prev)
--
2.20.1.7.g153144c

2022-01-09 17:37:21

by Jens Axboe

Subject: Re: [PATCH -next] block: fix old-style declaration

On Fri, 7 Jan 2022 08:52:28 +0800, Yang Li wrote:
> Move the 'inline' keyword to the front of 'void'.
>
> Remove a warning found by clang(make W=1 LLVM=1)
> ./include/linux/blk-mq.h:259:1: warning: ‘inline’ is not at beginning of
> declaration
>
>
> [...]

Applied, thanks!

[1/1] block: fix old-style declaration
commit: 292c33c95defd0b814fec1fc8cd60d16556cf7b8

Best regards,
--
Jens Axboe