2022-01-17 17:08:29

by zhenggy

Subject: [PATCH] block: Remove unnecessary variable assignment

The parameter "ret" should be zero when running to this line,
no need to set to zero again, remove it.

Signed-off-by: GuoYong Zheng <[email protected]>
---
block/blk-sysfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index e20eadf..bed4a2f 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -887,7 +887,6 @@ int blk_register_queue(struct gendisk *disk)
kobject_uevent(&q->elevator->kobj, KOBJ_ADD);
mutex_unlock(&q->sysfs_lock);

- ret = 0;
unlock:
mutex_unlock(&q->sysfs_dir_lock);

--
1.8.3.1

2022-01-18 02:32:05

by Jens Axboe

Subject: Re: [PATCH] block: Remove unnecessary variable assignment

On Mon, 17 Jan 2022 18:22:37 +0800, GuoYong Zheng wrote:
> The parameter "ret" should be zero when running to this line,
> no need to set to zero again, remove it.
>
>

Applied, thanks!

[1/1] block: Remove unnecessary variable assignment
commit: e6a2e5116e07ce5acc8698785c29e9e47f010fd5

Best regards,
--
Jens Axboe