2022-01-22 00:33:26

by Kiwoong Kim

Subject: [PATCH v2] scsi: ufs: see link lost as fatal

v1 -> v2: modify comment

This event is raised when link is lost as specified
in UFSHCI spec and that means communication is
not possible. Thus initializing UFS interface needs to be done.

This patch is to make UFS driver see Link Lost as fatal by using
INT_FATAL_ERRORS. This lead to host reset whenever a link lost
interrupt occurs.

Signed-off-by: Kiwoong Kim <[email protected]>
---
drivers/scsi/ufs/ufshci.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index 6a295c8..a7ff0e5 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -142,7 +142,8 @@ static inline u32 ufshci_version(u32 major, u32 minor)
#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+ CRYPTO_ENGINE_FATAL_ERROR |\
+ UIC_LINK_LOST)

/* HCS - Host Controller Status 30h */
#define DEVICE_PRESENT 0x1
--
2.7.4

2022-01-25 08:56:13

by Martin K. Petersen

Subject: Re: [PATCH v2] scsi: ufs: see link lost as fatal

On Fri, 21 Jan 2022 14:37:55 +0900, Kiwoong Kim wrote:

> v1 -> v2: modify comment
>
> This event is raised when link is lost as specified
> in UFSHCI spec and that means communication is
> not possible. Thus initializing UFS interface needs to be done.
>
> This patch is to make UFS driver see Link Lost as fatal by using
> INT_FATAL_ERRORS. This lead to host reset whenever a link lost
> interrupt occurs.
>
> [...]

Applied to 5.17/scsi-fixes, thanks!

[1/1] scsi: ufs: see link lost as fatal
https://git.kernel.org/mkp/scsi/c/c99b9b230149

--
Martin K. Petersen Oracle Linux Engineering