2021-12-02 05:18:13

by Sandeep Maheswaram

[permalink] [raw]
Subject: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

Move USB2 controller and phy nodes from common dtsi file as it is
required only for SKU1 board and change the mode to host mode as
it will be used in host mode for SKU1.

Signed-off-by: Sandeep Maheswaram <[email protected]>
---
v2:
Squashed the two patches in v1 and changed the commit message.

arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 16 ----------------
2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 9b991ba..ffd483d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -80,3 +80,19 @@
qcom,pre-scaling = <1 1>;
};
};
+
+&usb_2 {
+ status = "okay";
+};
+
+&usb_2_dwc3 {
+ dr_mode = "host";
+};
+
+&usb_2_hsphy {
+ status = "okay";
+
+ vdda-pll-supply = <&vreg_l10c_0p8>;
+ vdda33-supply = <&vreg_l2b_3p0>;
+ vdda18-supply = <&vreg_l1c_1p8>;
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index d623d71..c54ad62 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -398,22 +398,6 @@
vdda-pll-supply = <&vreg_l1b_0p8>;
};

-&usb_2 {
- status = "okay";
-};
-
-&usb_2_dwc3 {
- dr_mode = "peripheral";
-};
-
-&usb_2_hsphy {
- status = "okay";
-
- vdda-pll-supply = <&vreg_l10c_0p8>;
- vdda33-supply = <&vreg_l2b_3p0>;
- vdda18-supply = <&vreg_l1c_1p8>;
-};
-
&uart7 {
status = "okay";

--
2.7.4



2021-12-02 15:46:42

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

On Thu, Dec 02, 2021 at 10:47:28AM +0530, Sandeep Maheswaram wrote:
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>

Reviewed-by: Matthias Kaehlcke <[email protected]>

2021-12-02 22:52:13

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-12-15 05:48:35

by Sandeep Maheswaram

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

Hi Bjorn,

On 12/3/2021 4:22 AM, Stephen Boyd wrote:
> Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
>> Move USB2 controller and phy nodes from common dtsi file as it is
>> required only for SKU1 board and change the mode to host mode as
>> it will be used in host mode for SKU1.
>>
>> Signed-off-by: Sandeep Maheswaram <[email protected]>
>> ---
> Reviewed-by: Stephen Boyd <[email protected]>
Can you merge this change in qcom tree?

2022-01-10 04:56:19

by Sandeep Maheswaram

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

Hi Bjorn,

On 12/15/2021 11:18 AM, Sandeep Maheswaram wrote:
> Hi Bjorn,
>
> On 12/3/2021 4:22 AM, Stephen Boyd wrote:
>> Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
>>> Move USB2 controller and phy nodes from common dtsi file as it is
>>> required only for SKU1 board and change the mode to host mode as
>>> it will be used in host mode for SKU1.
>>>
>>> Signed-off-by: Sandeep Maheswaram <[email protected]>
>>> ---
>> Reviewed-by: Stephen Boyd <[email protected]>
> Can you merge this change in qcom tree?

Is this patch merged in qcom tree ? If not can you please do so.

Regards

Sandeep



2022-01-10 19:09:22

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

On Sun 09 Jan 20:56 PST 2022, Sandeep Maheswaram wrote:

> Hi Bjorn,
>
> On 12/15/2021 11:18 AM, Sandeep Maheswaram wrote:
> > Hi Bjorn,
> >
> > On 12/3/2021 4:22 AM, Stephen Boyd wrote:
> > > Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
> > > > Move USB2 controller and phy nodes from common dtsi file as it is
> > > > required only for SKU1 board and change the mode to host mode as
> > > > it will be used in host mode for SKU1.
> > > >
> > > > Signed-off-by: Sandeep Maheswaram <[email protected]>
> > > > ---
> > > Reviewed-by: Stephen Boyd <[email protected]>
> > Can you merge this change in qcom tree?
>
> Is this patch merged in qcom tree ? If not can you please do so.
>

Sorry, I seem to have missed this in the patch list. Will pick it up for
v5.18.

Thanks,
Bjorn

2022-02-01 20:46:54

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1

On Thu, 2 Dec 2021 10:47:28 +0530, Sandeep Maheswaram wrote:
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
>
>

Applied, thanks!

[1/1] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
commit: 1b968998a3cbd346e7b01a5b41f4c88b979ae7d5

Best regards,
--
Bjorn Andersson <[email protected]>