2022-02-09 12:52:33

by Fabrice Gasnier

Subject: [PATCH 0/2] ARM: dts: stm32: remove timer duplicate unit-address on stm32f7 series

Remove a series of warnings seen when building with W=1, like:
Warning (unique_unit_address): /soc/timer@40000c00: duplicate unit-address
(also used in node /soc/timers@40000c00)

This approach is based on some discussions[1], to restructure the dtsi
and dts files.
[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/

arch/arm/boot/dts/stm32746g-eval.dts | 12 +++++++++
arch/arm/boot/dts/stm32f746-disco.dts | 12 +++++++++
arch/arm/boot/dts/stm32f746.dtsi | 47 -----------------------------------
arch/arm/boot/dts/stm32f769-disco.dts | 12 +++++++++
4 files changed, 36 insertions(+), 47 deletions(-)

--
2.7.4

2022-02-09 13:53:18

by Fabrice Gasnier

Subject: [PATCH 1/2] ARM: dts: stm32: remove some timer duplicate unit-address on stm32f7 series

Several unused "timer" are duplicate nodes of "timers" nodes.
There are two dt-schemas:
- timer/st,stm32-timer.yaml: A timer is needed on STM32F7 series, on all
boards, to act as clockevent.
- mfd/st,stm32-timers.yaml: Timers can be used for other purpose.

By default, timer5 is left enabled to be used as clockevent. Remove all
other timer clockevent nodes that are currently unused and duplicated.

This removes several messages: Warning (unique_unit_address): /soc/timer@..
duplicate unit-address (also used in node /soc/timers@...)

Signed-off-by: Fabrice Gasnier <[email protected]>
---
arch/arm/boot/dts/stm32f746.dtsi | 40 ----------------------------------------
1 file changed, 40 deletions(-)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 014b416..a4f5c6a 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -75,14 +75,6 @@
};

soc {
- timer2: timer@40000000 {
- compatible = "st,stm32-timer";
- reg = <0x40000000 0x400>;
- interrupts = <28>;
- clocks = <&rcc 0 STM32F7_APB1_CLOCK(TIM2)>;
- status = "disabled";
- };
-
timers2: timers@40000000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -105,14 +97,6 @@
};
};

- timer3: timer@40000400 {
- compatible = "st,stm32-timer";
- reg = <0x40000400 0x400>;
- interrupts = <29>;
- clocks = <&rcc 0 STM32F7_APB1_CLOCK(TIM3)>;
- status = "disabled";
- };
-
timers3: timers@40000400 {
#address-cells = <1>;
#size-cells = <0>;
@@ -135,14 +119,6 @@
};
};

- timer4: timer@40000800 {
- compatible = "st,stm32-timer";
- reg = <0x40000800 0x400>;
- interrupts = <30>;
- clocks = <&rcc 0 STM32F7_APB1_CLOCK(TIM4)>;
- status = "disabled";
- };
-
timers4: timers@40000800 {
#address-cells = <1>;
#size-cells = <0>;
@@ -194,14 +170,6 @@
};
};

- timer6: timer@40001000 {
- compatible = "st,stm32-timer";
- reg = <0x40001000 0x400>;
- interrupts = <54>;
- clocks = <&rcc 0 STM32F7_APB1_CLOCK(TIM6)>;
- status = "disabled";
- };
-
timers6: timers@40001000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -218,14 +186,6 @@
};
};

- timer7: timer@40001400 {
- compatible = "st,stm32-timer";
- reg = <0x40001400 0x400>;
- interrupts = <55>;
- clocks = <&rcc 0 STM32F7_APB1_CLOCK(TIM7)>;
- status = "disabled";
- };
-
timers7: timers@40001400 {
#address-cells = <1>;
#size-cells = <0>;
--
2.7.4

2022-02-14 11:28:16

by Alexandre TORGUE

Subject: Re: [PATCH 0/2] ARM: dts: stm32: remove timer duplicate unit-address on stm32f7 series

Hi Fabrice

On 2/9/22 11:48, Fabrice Gasnier wrote:
> Remove a series of warnings seen when building with W=1, like:
> Warning (unique_unit_address): /soc/timer@40000c00: duplicate unit-address
> (also used in node /soc/timers@40000c00)
>
> This approach is based on some discussions[1], to restructure the dtsi
> and dts files.
> [1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> arch/arm/boot/dts/stm32746g-eval.dts | 12 +++++++++
> arch/arm/boot/dts/stm32f746-disco.dts | 12 +++++++++
> arch/arm/boot/dts/stm32f746.dtsi | 47 -----------------------------------
> arch/arm/boot/dts/stm32f769-disco.dts | 12 +++++++++
> 4 files changed, 36 insertions(+), 47 deletions(-)
>

Series applied on stm32-next.

Cheers
Alex