Subject: [PATCH v4 3/5] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

Rename the edp_out label in the sc7280 platform to mdss_edp_out.

Signed-off-by: Sankeerth Billakanti <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-crd.dts | 10 +++++-----
arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
index 6dba5ac..af40e14 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
@@ -69,7 +69,7 @@
port@0 {
reg = <0>;
edp_panel_in: endpoint {
- remote-endpoint = <&edp_out>;
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
@@ -129,10 +129,6 @@ ap_ts_pen_1v8: &i2c13 {
};
};

-&edp_out {
- remote-endpoint = <&edp_panel_in>;
-};
-
&mdss {
status = "okay";
};
@@ -156,6 +152,10 @@ ap_ts_pen_1v8: &i2c13 {
/delete-property/ pinctrl-0;
};

+&mdss_edp_out {
+ remote-endpoint = <&edp_panel_in>;
+};
+
&mdss_edp_phy {
status = "okay";

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 3572399..eca403a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3066,7 +3066,7 @@

port@1 {
reg = <1>;
- edp_out: endpoint { };
+ mdss_edp_out: endpoint { };
};
};

--
2.7.4



2022-02-11 03:53:54

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v4 3/5] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote:

> Rename the edp_out label in the sc7280 platform to mdss_edp_out.

Next week, or in the next product, it might not be obvious why we did
this change. So please continue this sentence with something like "so
that the nodes are grouped together when sorted in the dts".

>
> Signed-off-by: Sankeerth Billakanti <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 10 +++++-----
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index 6dba5ac..af40e14 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -69,7 +69,7 @@
> port@0 {
> reg = <0>;
> edp_panel_in: endpoint {
> - remote-endpoint = <&edp_out>;
> + remote-endpoint = <&mdss_edp_out>;
> };
> };
> };
> @@ -129,10 +129,6 @@ ap_ts_pen_1v8: &i2c13 {
> };
> };
>
> -&edp_out {

You just added this node in patch 2 and now you change it immediately.
If you reorder the two patches the history will be cleaner.

Thanks,
Bjorn

> - remote-endpoint = <&edp_panel_in>;
> -};
> -
> &mdss {
> status = "okay";
> };
> @@ -156,6 +152,10 @@ ap_ts_pen_1v8: &i2c13 {
> /delete-property/ pinctrl-0;
> };
>
> +&mdss_edp_out {
> + remote-endpoint = <&edp_panel_in>;
> +};
> +
> &mdss_edp_phy {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 3572399..eca403a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3066,7 +3066,7 @@
>
> port@1 {
> reg = <1>;
> - edp_out: endpoint { };
> + mdss_edp_out: endpoint { };
> };
> };
>
> --
> 2.7.4
>