From: Wang Qing <[email protected]>
It is better to use time_is_xxx() directly instead of jiffies judgment
for understanding.
Batch them in a series suggested by Joe.
Wang Qing (14):
block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment
clk: mvebu: use time_is_before_eq_jiffies() instead of jiffies judgment
gpu: drm: i915: use time_is_after_jiffies() instead of jiffies judgment
gpu: drm: radeon: use time_is_before_jiffies() instead of jiffies judgment
hid: use time_is_after_jiffies() instead of jiffies judgment
input: serio: use time_is_before_jiffies() instead of jiffies judgment
md: use time_is_before_jiffies(() instead of jiffies judgment
md: use time_is_before_eq_jiffies() instead of jiffies judgment
media: si21xx: use time_is_before_jiffies() instead of jiffies judgment
media: stv0299: use time_is_before_jiffies() instead of jiffies judgment
media: tda8083: use time_is_after_jiffies() instead of jiffies judgment
media: wl128x: use time_is_before_jiffies() instead of jiffies judgment
media: vivid: use time_is_after_jiffies() instead of jiffies judgment
drivers/block/xen-blkback/blkback.c | 5 +++--
drivers/clk/mvebu/armada-37xx-periph.c | 3 ++-
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +-
drivers/gpu/drm/radeon/radeon_pm.c | 3 ++-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/input/serio/ps2-gpio.c | 4 ++--
drivers/md/dm-thin.c | 2 +-
drivers/md/dm-writecache.c | 5 +++--
drivers/media/dvb-frontends/si21xx.c | 2 +-
drivers/media/dvb-frontends/stv0299.c | 4 ++--
drivers/media/dvb-frontends/tda8083.c | 2 +-
drivers/media/radio/wl128x/fmdrv_common.c | 3 ++-
drivers/media/test-drivers/vivid/vivid-kthread-cap.c | 3 ++-
drivers/media/test-drivers/vivid/vivid-kthread-out.c | 3 ++-
drivers/media/test-drivers/vivid/vivid-kthread-touch.c | 3 ++-
drivers/media/test-drivers/vivid/vivid-sdr-cap.c | 3 ++-
17 files changed, 31 insertions(+), 22 deletions(-)
--
2.7.4
From: Wang Qing <[email protected]>
It is better to use time_xxx() directly instead of jiffies judgment
for understanding.
Signed-off-by: Wang Qing <[email protected]>
---
drivers/block/xen-blkback/blkback.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index d1e2646..aecc1f4
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -42,6 +42,7 @@
#include <linux/delay.h>
#include <linux/freezer.h>
#include <linux/bitmap.h>
+#include <linux/jiffies.h>
#include <xen/events.h>
#include <xen/page.h>
@@ -134,8 +135,8 @@ module_param(log_stats, int, 0644);
static inline bool persistent_gnt_timeout(struct persistent_gnt *persistent_gnt)
{
- return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
- HZ * pgrant_timeout);
+ return pgrant_timeout && time_is_before_eq_jiffies(
+ persistent_gnt->last_used + HZ * pgrant_timeout);
}
#define vaddr(page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))
--
2.7.4
On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> It is better to use time_is_xxx() directly instead of jiffies judgment
> for understanding.
Hi Wang,
"judgement" doesn't really make sense as a description to an English
speaker. The following a commit desription (for all of these series)
is probably going to be a bit more understable:
Use the helper function time_is_{before,after}_jiffies() to improve
code readability.
Cheers,
- Ted
From: Wang Qing <[email protected]>
It is better to use time_xxx() directly instead of jiffies judgment
for understanding.
Signed-off-by: Wang Qing <[email protected]>
---
drivers/media/dvb-frontends/si21xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
index 001b235..1c6cf76
--- a/drivers/media/dvb-frontends/si21xx.c
+++ b/drivers/media/dvb-frontends/si21xx.c
@@ -336,7 +336,7 @@ static int si21xx_wait_diseqc_idle(struct si21xx_state *state, int timeout)
dprintk("%s\n", __func__);
while ((si21_readreg(state, LNB_CTRL_REG_1) & 0x8) == 8) {
- if (jiffies - start > timeout) {
+ if (time_is_before_jiffies(start + timeout)) {
dprintk("%s: timeout!!\n", __func__);
return -ETIMEDOUT;
}
--
2.7.4
>>On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote:
>> From: Wang Qing <[email protected]>
>>
>> It is better to use time_is_xxx() directly instead of jiffies judgment
>> for understanding.
>
>Hi Wang,
>
>"judgement" doesn't really make sense as a description to an English
>speaker. The following a commit desription (for all of these series)
>is probably going to be a bit more understable:
>
>Use the helper function time_is_{before,after}_jiffies() to improve
>code readability.
>
>Cheers,
>
> - Ted
I see, it will be corrected in V3.
I'll wait a few days if there are any other disagreements.
Thanks,
Qing
From: Wang Qing <[email protected]>
It is better to use time_xxx() directly instead of jiffies judgment
for understanding.
Signed-off-by: Wang Qing <[email protected]>
---
drivers/media/radio/wl128x/fmdrv_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 6142484d..a599d08
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -23,6 +23,7 @@
#include <linux/firmware.h>
#include <linux/module.h>
#include <linux/nospec.h>
+#include <linux/jiffies.h>
#include "fmdrv.h"
#include "fmdrv_v4l2.h"
@@ -342,7 +343,7 @@ static void send_tasklet(struct tasklet_struct *t)
return;
/* Check, is there any timeout happened to last transmitted packet */
- if ((jiffies - fmdev->last_tx_jiffies) > FM_DRV_TX_TIMEOUT) {
+ if (time_is_before_jiffies(fmdev->last_tx_jiffies + FM_DRV_TX_TIMEOUT)) {
fmerr("TX timeout occurred\n");
atomic_set(&fmdev->tx_cnt, 1);
}
--
2.7.4