2022-02-11 04:33:34

by 王擎

Subject: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

From: Wang Qing <[email protected]>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
static unsigned long prev_sync;
uint64_t usec;

- if (prev_sync && jiffies - prev_sync < 20 * HZ)
+ if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
return;

prev_sync = jiffies;
--
2.7.4

2022-02-12 18:23:15

by srinivas pandruvada

Subject: Re: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> It is better to use time_xxx() directly instead of jiffies judgment
> for understanding.
>
> Signed-off-by: Wang Qing <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 8ccb246..15e1423
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct
> ishtp_device *dev)
>         static unsigned long    prev_sync;
>         uint64_t        usec;
>  
> -       if (prev_sync && jiffies - prev_sync < 20 * HZ)
> +       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
>                 return;
>  
>         prev_sync = jiffies;