2022-02-15 01:59:53

by 王擎

Subject: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

From: Wang Qing <[email protected]>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
static unsigned long prev_sync;
uint64_t usec;

- if (prev_sync && jiffies - prev_sync < 20 * HZ)
+ if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
return;

prev_sync = jiffies;
--
2.7.4

2022-02-15 12:51:11

by Benjamin Tissoires

Subject: Re: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

On Tue, Feb 15, 2022 at 2:56 AM Qing Wang <[email protected]> wrote:
>
> From: Wang Qing <[email protected]>
>
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
>
> Signed-off-by: Wang Qing <[email protected]>
> Acked-by: Srinivas Pandruvada <[email protected]>

FWIW, this one is
Acked-by: Benjamin Tissoires <[email protected]>

Wang, is there any plan to take this series through the trivial tree
or should each maintainer take the matching patches?

Cheers,
Benjamin

> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 8ccb246..15e1423
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
> static unsigned long prev_sync;
> uint64_t usec;
>
> - if (prev_sync && jiffies - prev_sync < 20 * HZ)
> + if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
> return;
>
> prev_sync = jiffies;
> --
> 2.7.4
>

2022-02-15 14:48:15

by 王擎

Subject: RE: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

 
>>On Tue, Feb 15, 2022 at 2:56 AM Qing Wang <[email protected]> wrote:
>>
>> From: Wang Qing <[email protected]>
>>
>> Use the helper function time_is_{before,after}_jiffies() to improve
>> code readability.
>>
>> Signed-off-by: Wang Qing <[email protected]>
>> Acked-by: Srinivas Pandruvada <[email protected]>
>
>FWIW, this one is
>Acked-by: Benjamin Tissoires <[email protected]>
>
>Wang, is there any plan to take this series through the trivial tree

That's why I batch them in a series, but I don't know how to take
this series through the trivial tree directly.

I would appreciate if you could help.

Thanks,
Wang

>or should each maintainer take the matching patches?
>
>Cheers,
>Benjamin
>
>> ---
>>  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
>> index 8ccb246..15e1423
>> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
>> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
>> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
>>         static unsigned long    prev_sync;
>>         uint64_t        usec;
>>
>> -       if (prev_sync && jiffies - prev_sync < 20 * HZ)
>> +       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
>>                 return;
>>
>>         prev_sync = jiffies;
>> --
>> 2.7.4
>>