2021-12-30 15:11:48

by Maksim Kiselev

[permalink] [raw]
Subject: [PATCH] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5

T1040RDB has two RTL8211E-VB phys which requires setting
of internal delays for correct work.

Changing the phy-connection-type property to `rgmii-id`
will fix this issue.

Signed-off-by: Maxim Kiselev <[email protected]>
Reviewed-by: Maxim Kochetkov <[email protected]>
---
arch/powerpc/boot/dts/fsl/t104xrdb.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
index 099a598c74c00..bfe1ed5be3374 100644
--- a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
@@ -139,12 +139,12 @@ pca9546@77 {
fman@400000 {
ethernet@e6000 {
phy-handle = <&phy_rgmii_0>;
- phy-connection-type = "rgmii";
+ phy-connection-type = "rgmii-id";
};

ethernet@e8000 {
phy-handle = <&phy_rgmii_1>;
- phy-connection-type = "rgmii";
+ phy-connection-type = "rgmii-id";
};

mdio0: mdio@fc000 {
--
2.32.0



2022-01-13 12:35:37

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5

On Thu, Dec 30, 2021 at 06:11:21PM +0300, Maxim Kiselev wrote:
> T1040RDB has two RTL8211E-VB phys which requires setting
> of internal delays for correct work.
>
> Changing the phy-connection-type property to `rgmii-id`
> will fix this issue.
>
> Signed-off-by: Maxim Kiselev <[email protected]>
> Reviewed-by: Maxim Kochetkov <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>

> arch/powerpc/boot/dts/fsl/t104xrdb.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> index 099a598c74c00..bfe1ed5be3374 100644
> --- a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> @@ -139,12 +139,12 @@ pca9546@77 {
> fman@400000 {
> ethernet@e6000 {
> phy-handle = <&phy_rgmii_0>;
> - phy-connection-type = "rgmii";
> + phy-connection-type = "rgmii-id";
> };
>
> ethernet@e8000 {
> phy-handle = <&phy_rgmii_1>;
> - phy-connection-type = "rgmii";
> + phy-connection-type = "rgmii-id";
> };
>
> mdio0: mdio@fc000 {
> --
> 2.32.0
>


2022-02-15 05:40:25

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5

On Thu, 30 Dec 2021 18:11:21 +0300, Maxim Kiselev wrote:
> T1040RDB has two RTL8211E-VB phys which requires setting
> of internal delays for correct work.
>
> Changing the phy-connection-type property to `rgmii-id`
> will fix this issue.
>
>
> [...]

Applied to powerpc/next.

[1/1] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5
https://git.kernel.org/powerpc/c/17846485dff91acce1ad47b508b633dffc32e838

cheers