2022-02-16 11:46:14

by Yue Haibing

Subject: [PATCH net-next] net: hns3: Remove unused inline function hclge_is_reset_pending()

This is unused since commit 8e2288cad6cb ("net: hns3: refactor PF
cmdq init and uninit APIs with new common APIs").

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
index adfb26e79262..3c5e76eaf90b 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
@@ -1060,11 +1060,6 @@ static inline int hclge_get_queue_id(struct hnae3_queue *queue)
return tqp->index;
}

-static inline bool hclge_is_reset_pending(struct hclge_dev *hdev)
-{
- return !!hdev->reset_pending;
-}
-
int hclge_inform_reset_assert_to_vf(struct hclge_vport *vport);
int hclge_cfg_mac_speed_dup(struct hclge_dev *hdev, int speed, u8 duplex);
int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
--
2.17.1

2022-02-17 08:00:19

by wangjie (L)

Subject: Re: [PATCH net-next] net: hns3: Remove unused inline function hclge_is_reset_pending()

Reviewed-by: Jie Wang <[email protected]>

On 2022/2/16 19:35, YueHaibing wrote:
> This is unused since commit 8e2288cad6cb ("net: hns3: refactor PF
> cmdq init and uninit APIs with new common APIs").
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> index adfb26e79262..3c5e76eaf90b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> @@ -1060,11 +1060,6 @@ static inline int hclge_get_queue_id(struct hnae3_queue *queue)
> return tqp->index;
> }
>
> -static inline bool hclge_is_reset_pending(struct hclge_dev *hdev)
> -{
> - return !!hdev->reset_pending;
> -}
> -
> int hclge_inform_reset_assert_to_vf(struct hclge_vport *vport);
> int hclge_cfg_mac_speed_dup(struct hclge_dev *hdev, int speed, u8 duplex);
> int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
>

2022-02-17 14:02:41

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: hns3: Remove unused inline function hclge_is_reset_pending()

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 16 Feb 2022 19:35:07 +0800 you wrote:
> This is unused since commit 8e2288cad6cb ("net: hns3: refactor PF
> cmdq init and uninit APIs with new common APIs").
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 5 -----
> 1 file changed, 5 deletions(-)

Here is the summary with links:
- [net-next] net: hns3: Remove unused inline function hclge_is_reset_pending()
https://git.kernel.org/netdev/net-next/c/8aa69d348261

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html