2022-02-21 08:45:09

by Rohit Agarwal

Subject: [PATCH v3 1/7] dt-bindings: mailbox: Add binding for SDX65 APCS

Add devicetree YAML binding for SDX65 APCS GCC block. The APCS block
acts as the mailbox controller and also provides a clock output and
takes 3 clock sources (pll, aux, ref) as input.

Signed-off-by: Rohit Agarwal <[email protected]>
---
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 01e9d91..688ae8b 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -91,6 +91,7 @@ allOf:
compatible:
enum:
- qcom,sdx55-apcs-gcc
+ - qcom,sdx65-apcs-gcc
then:
properties:
clocks:
--
2.7.4

2022-02-24 22:14:34

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/7] dt-bindings: mailbox: Add binding for SDX65 APCS

On Mon, Feb 21, 2022 at 10:52:27AM +0530, Rohit Agarwal wrote:
> Add devicetree YAML binding for SDX65 APCS GCC block. The APCS block
> acts as the mailbox controller and also provides a clock output and
> takes 3 clock sources (pll, aux, ref) as input.
>
> Signed-off-by: Rohit Agarwal <[email protected]>
> ---
> Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 01e9d91..688ae8b 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -91,6 +91,7 @@ allOf:
> compatible:
> enum:
> - qcom,sdx55-apcs-gcc
> + - qcom,sdx65-apcs-gcc

Did you test this on your dts file? This doesn't work. You need to also
add the compatible to the main 'compatible' schema.

> then:
> properties:
> clocks:
> --
> 2.7.4
>
>