2022-02-15 09:26:14

by Bjorn Andersson

Subject: [PATCH] soc: qcom: mdt_loader: Fix split-firmware condition

The updated condition checking if a segment can be found in the loaded
firmware blob, or need to be loaded from a separate file, incorrectly
classifies segments that ends at the end of the loaded blob. The result
is that the mdt loader attempts to load the segment from a separate
file.

Correct the conditional to use the loaded segment instead.

Fixes: ea90330fa329 ("soc: qcom: mdt_loader: Extend check for split firmware")
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/soc/qcom/mdt_loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
index f0b1d969567c..366db493579b 100644
--- a/drivers/soc/qcom/mdt_loader.c
+++ b/drivers/soc/qcom/mdt_loader.c
@@ -329,7 +329,7 @@ static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,
ptr = mem_region + offset;

if (phdr->p_filesz && phdr->p_offset < fw->size &&
- phdr->p_offset + phdr->p_filesz < fw->size) {
+ phdr->p_offset + phdr->p_filesz <= fw->size) {
/* Firmware is large enough to be non-split */
if (phdr->p_offset + phdr->p_filesz > fw->size) {
dev_err(dev, "file %s segment %d would be truncated\n",
--
2.33.1

2022-02-22 05:22:52

by Vinod Koul

Subject: Re: [PATCH] soc: qcom: mdt_loader: Fix split-firmware condition

On 14-02-22, 19:48, Bjorn Andersson wrote:
> The updated condition checking if a segment can be found in the loaded
> firmware blob, or need to be loaded from a separate file, incorrectly
> classifies segments that ends at the end of the loaded blob. The result
> is that the mdt loader attempts to load the segment from a separate
> file.
>
> Correct the conditional to use the loaded segment instead.
>
> Fixes: ea90330fa329 ("soc: qcom: mdt_loader: Extend check for split firmware")
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Vinod Koul <[email protected]>

--
~Vinod

2022-02-24 21:29:03

by Bjorn Andersson

Subject: Re: (subset) [PATCH] soc: qcom: mdt_loader: Fix split-firmware condition

On Mon, 14 Feb 2022 19:48:19 -0800, Bjorn Andersson wrote:
> The updated condition checking if a segment can be found in the loaded
> firmware blob, or need to be loaded from a separate file, incorrectly
> classifies segments that ends at the end of the loaded blob. The result
> is that the mdt loader attempts to load the segment from a separate
> file.
>
> Correct the conditional to use the loaded segment instead.
>
> [...]

Applied, thanks!

[1/1] soc: qcom: mdt_loader: Fix split-firmware condition
commit: a1b019872693c74d919db4e267f451fc7af9a21c

Best regards,
--
Bjorn Andersson <[email protected]>