During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value >= 0 as success.
Signed-off-by: Zheyu Ma <[email protected]>
---
drivers/scsi/wd719x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 1a7947554581..2b24ef387d57 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -904,7 +904,8 @@ static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d)
if (err)
goto fail;
- if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) {
+ err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+ if (err) {
dev_warn(&pdev->dev, "Unable to set 32-bit DMA mask\n");
goto disable_device;
}
--
2.25.1
On 28/02/2022 15:54, Zheyu Ma wrote:
> During the process of driver probing, the probe function should return < 0
> for failure, otherwise, the kernel will treat value >= 0 as success.
"So set 'err' to the error value returned by dma_set_mask() in case of failure"
Otherwise looks good to me,
Reviewed-by: Johannes Thumshirn <[email protected]>
Zheyu,
> During the process of driver probing, the probe function should return
> < 0 for failure, otherwise, the kernel will treat value >= 0 as
> success.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Mon, 28 Feb 2022 14:54:15 +0000, Zheyu Ma wrote:
> During the process of driver probing, the probe function should return < 0
> for failure, otherwise, the kernel will treat value >= 0 as success.
>
>
Applied to 5.18/scsi-queue, thanks!
[1/1] scsi: wd719x: Return proper error code when dma_set_mask() fails
https://git.kernel.org/mkp/scsi/c/98cdcd6c6b4a
--
Martin K. Petersen Oracle Linux Engineering