2022-03-17 06:03:26

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -next] sched/headers: ARM needs asm/paravirt_api_clock.h

Add <asm/paravirt_api_clock.h> for arch/arm/.

Fixes this build error:

In file included from ../kernel/sched/core.c:81:
../kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
87 | # include <asm/paravirt_api_clock.h>

Fixes: 4ff8f2ca6ccd ("sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
KernelVersion: linux-next-20220316

arch/arm/include/asm/paravirt_api_clock.h | 1 +
1 file changed, 1 insertion(+)

--- /dev/null
+++ linux-next-20220316/arch/arm/include/asm/paravirt_api_clock.h
@@ -0,0 +1 @@
+#include <asm/paravirt.h>


2022-03-21 21:59:04

by Nathan Chancellor

[permalink] [raw]
Subject: Re: [PATCH -next] sched/headers: ARM needs asm/paravirt_api_clock.h

On Wed, Mar 16, 2022 at 01:41:46PM -0700, Randy Dunlap wrote:
> Add <asm/paravirt_api_clock.h> for arch/arm/.
>
> Fixes this build error:
>
> In file included from ../kernel/sched/core.c:81:
> ../kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
> 87 | # include <asm/paravirt_api_clock.h>
>
> Fixes: 4ff8f2ca6ccd ("sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Nathan Chancellor <[email protected]>

This needs to go into -tip to avoid breaking the build for ARM
all{mod,yes}config. It looks like the pull has already been sent though
:/

> ---
> KernelVersion: linux-next-20220316
>
> arch/arm/include/asm/paravirt_api_clock.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- /dev/null
> +++ linux-next-20220316/arch/arm/include/asm/paravirt_api_clock.h
> @@ -0,0 +1 @@
> +#include <asm/paravirt.h>
>

2022-03-22 08:03:20

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH -next] sched/headers: ARM needs asm/paravirt_api_clock.h


* Nathan Chancellor <[email protected]> wrote:

> On Wed, Mar 16, 2022 at 01:41:46PM -0700, Randy Dunlap wrote:
> > Add <asm/paravirt_api_clock.h> for arch/arm/.
> >
> > Fixes this build error:
> >
> > In file included from ../kernel/sched/core.c:81:
> > ../kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
> > 87 | # include <asm/paravirt_api_clock.h>
> >
> > Fixes: 4ff8f2ca6ccd ("sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies")
> > Signed-off-by: Randy Dunlap <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Cc: Russell King <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
>
> Reviewed-by: Nathan Chancellor <[email protected]>

Applied, thanks!

Ingo

Subject: [tip: sched/core] sched/headers: ARM needs asm/paravirt_api_clock.h too

The following commit has been merged into the sched/core branch of tip:

Commit-ID: ffea9fb319360b9ead8befac6bb2db2b54fd53e6
Gitweb: https://git.kernel.org/tip/ffea9fb319360b9ead8befac6bb2db2b54fd53e6
Author: Randy Dunlap <[email protected]>
AuthorDate: Wed, 16 Mar 2022 13:41:46 -07:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Tue, 22 Mar 2022 08:53:10 +01:00

sched/headers: ARM needs asm/paravirt_api_clock.h too

Add <asm/paravirt_api_clock.h> for arch/arm/, mapped to <asm/paravirt.h>,
to simplify #ifdeffery in generic code.

Fixes this build error introduced by the scheduler tree:

In file included from ../kernel/sched/core.c:81:
../kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
87 | # include <asm/paravirt_api_clock.h>

Reviewed-by: Nathan Chancellor <[email protected]>
Fixes: 4ff8f2ca6ccd ("sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies")
Signed-off-by: Randy Dunlap <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
arch/arm/include/asm/paravirt_api_clock.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 arch/arm/include/asm/paravirt_api_clock.h

diff --git a/arch/arm/include/asm/paravirt_api_clock.h b/arch/arm/include/asm/paravirt_api_clock.h
new file mode 100644
index 0000000..65ac7ce
--- /dev/null
+++ b/arch/arm/include/asm/paravirt_api_clock.h
@@ -0,0 +1 @@
+#include <asm/paravirt.h>