2022-03-25 17:36:15

by QintaoShen

[permalink] [raw]
Subject: [PATCH v1] clk: socfpga: Fix a potential memory leak for kzalloc()

kfree() is missing on an error path to free the memory allocated by kzalloc().

Signed-off-by: QintaoShen <[email protected]>
---
drivers/clk/socfpga/clk-gate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c
index 53d6e3e..0ca5e00 100644
--- a/drivers/clk/socfpga/clk-gate.c
+++ b/drivers/clk/socfpga/clk-gate.c
@@ -188,8 +188,10 @@ void __init socfpga_gate_init(struct device_node *node)
return;

ops = kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL);
- if (WARN_ON(!ops))
+ if (WARN_ON(!ops)) {
+ kfree(socfpga_clk);
return;
+ }

rc = of_property_read_u32_array(node, "clk-gate", clk_gate, 2);
if (rc)
--
2.7.4