2022-04-06 05:49:40

by Sai Krishna Potthuri

Subject: [PATCH 1/2] dt-bindings: spi: cadence-quadspi: Add reset-gpios for Xilinx Versal OSPI

Add reset-gpios property to the properties list and marked as required
for Xilinx Versal OSPI compatible. This is used to perform the HW reset
for OSPI flash device.

Signed-off-by: Sai Krishna Potthuri <[email protected]>
---
Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index 0a537fa3a641..56001eaf6365 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -19,6 +19,7 @@ allOf:
then:
required:
- power-domains
+ - reset-gpios

properties:
compatible:
@@ -78,6 +79,12 @@ properties:
power-domains:
maxItems: 1

+ reset-gpios:
+ description:
+ Contains a phandle and GPIO specifier for reset with the default active
+ state.
+ maxItems: 1
+
resets:
maxItems: 2

--
2.17.1

2022-04-06 19:46:22

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: spi: cadence-quadspi: Add reset-gpios for Xilinx Versal OSPI

On Tue, Apr 05, 2022 at 04:30:36PM +0530, Sai Krishna Potthuri wrote:
> Add reset-gpios property to the properties list and marked as required
> for Xilinx Versal OSPI compatible. This is used to perform the HW reset
> for OSPI flash device.
>
> Signed-off-by: Sai Krishna Potthuri <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> index 0a537fa3a641..56001eaf6365 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -19,6 +19,7 @@ allOf:
> then:
> required:
> - power-domains
> + - reset-gpios
>
> properties:
> compatible:
> @@ -78,6 +79,12 @@ properties:
> power-domains:
> maxItems: 1
>
> + reset-gpios:
> + description:
> + Contains a phandle and GPIO specifier for reset with the default active
> + state.

Other than 'for reset' that's every GPIO property. Just drop unless you
have something specific to cdns,qspi-nor to say.

However, a reset for the flash device belongs in the flash device node,
not the controller node.

Rob