2022-03-18 11:17:10

by Cristian Marussi

Subject: [PATCH] firmware: arm_scmi: Fix sorting of retrieved clock rates

During SCMI Clock protocol initialization, after having retrieved from the
SCMI platform all the available discrete rates for a specific clock, the
clock rates array is sorted, unfortunately using a pointer to its end as
a base instead of its start, so that sorting does not work.

Fix invocation of sort() passing as base a pointer to the start of the
retrieved clock rates array.

Fixes: dccec73de91 ("firmware: arm_scmi: Keep the discrete clock rates sorted")
Signed-off-by: Cristian Marussi <[email protected]>
---
drivers/firmware/arm_scmi/clock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
index cf6fed6dec77..ef6431c6eb1c 100644
--- a/drivers/firmware/arm_scmi/clock.c
+++ b/drivers/firmware/arm_scmi/clock.c
@@ -210,7 +210,8 @@ scmi_clock_describe_rates_get(const struct scmi_protocol_handle *ph, u32 clk_id,

if (rate_discrete && rate) {
clk->list.num_rates = tot_rate_cnt;
- sort(rate, tot_rate_cnt, sizeof(*rate), rate_cmp_func, NULL);
+ sort(clk->list.rates, tot_rate_cnt, sizeof(*rate),
+ rate_cmp_func, NULL);
}

clk->rate_discrete = rate_discrete;
--
2.32.0

2022-04-06 14:41:00

by Sudeep Holla

Subject: Re: [PATCH] firmware: arm_scmi: Fix sorting of retrieved clock rates

On Fri, 18 Mar 2022 09:28:13 +0000, Cristian Marussi wrote:
> During SCMI Clock protocol initialization, after having retrieved from the
> SCMI platform all the available discrete rates for a specific clock, the
> clock rates array is sorted, unfortunately using a pointer to its end as
> a base instead of its start, so that sorting does not work.
>
> Fix invocation of sort() passing as base a pointer to the start of the
> retrieved clock rates array.
>
> [...]

Applied to sudeep.holla/linux (fixes/scmi), thanks!

[1/1] firmware: arm_scmi: Fix sorting of retrieved clock rates
https://git.kernel.org/sudeep.holla/c/23274739a5

--
Regards,
Sudeep