2022-04-07 09:39:06

by Andrea Parri

Subject: [PATCH 0/2] storvsc, netvsc: Improve logging

Two small (and independent) patches to augment and "standardize" the error
messages.

Thanks,
Andrea

Andrea Parri (Microsoft) (2):
scsi: storvsc: Print value of invalid ID in
storvsc_on_channel_callback()
hv_netvsc: Print value of invalid ID in
netvsc_send_{completion,tx_complete}()

drivers/net/hyperv/netvsc.c | 8 ++++----
drivers/scsi/storvsc_drv.c | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)

--
2.25.1

2022-04-07 10:31:24

by Andrea Parri

Subject: [PATCH 2/2] hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_complete}()

That being useful for debugging purposes.

Notice that the packet descriptor is in "private" guest memory, so
that Hyper-V can not tamper with it.

While at it, remove two unnecessary u64-casts.

Signed-off-by: Andrea Parri (Microsoft) <[email protected]>
---
drivers/net/hyperv/netvsc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 9442f751ad3aa..4061af5baaea3 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -792,9 +792,9 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
int queue_sends;
u64 cmd_rqst;

- cmd_rqst = channel->request_addr_callback(channel, (u64)desc->trans_id);
+ cmd_rqst = channel->request_addr_callback(channel, desc->trans_id);
if (cmd_rqst == VMBUS_RQST_ERROR) {
- netdev_err(ndev, "Incorrect transaction id\n");
+ netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
return;
}

@@ -854,9 +854,9 @@ static void netvsc_send_completion(struct net_device *ndev,
/* First check if this is a VMBUS completion without data payload */
if (!msglen) {
cmd_rqst = incoming_channel->request_addr_callback(incoming_channel,
- (u64)desc->trans_id);
+ desc->trans_id);
if (cmd_rqst == VMBUS_RQST_ERROR) {
- netdev_err(ndev, "Invalid transaction id\n");
+ netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
return;
}

--
2.25.1

2022-04-08 04:44:11

by patchwork-bot+netdevbpf

Subject: Re: [PATCH 0/2] storvsc, netvsc: Improve logging

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 7 Apr 2022 06:40:32 +0200 you wrote:
> Two small (and independent) patches to augment and "standardize" the error
> messages.
>
> Thanks,
> Andrea
>
> Andrea Parri (Microsoft) (2):
> scsi: storvsc: Print value of invalid ID in
> storvsc_on_channel_callback()
> hv_netvsc: Print value of invalid ID in
> netvsc_send_{completion,tx_complete}()
>
> [...]

Here is the summary with links:
- [1/2] scsi: storvsc: Print value of invalid ID in storvsc_on_channel_callback()
(no matching commit)
- [2/2] hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_complete}()
https://git.kernel.org/netdev/net-next/c/26894cd97116

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html