From: Keith Busch <[email protected]>
The function is not generally applicable enough to be included in the core
kernel header. Move it to block since it's the only subsystem using it.
Suggested-by: Linus Torvalds <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
---
include/linux/kernel.h | 9 ---------
include/linux/t10-pi.h | 9 +++++++++
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 08ba5995aa8b..a890428bcc1a 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -63,15 +63,6 @@
} \
)
-/**
- * lower_48_bits() - return bits 0-47 of a number
- * @n: the number we're accessing
- */
-static inline u64 lower_48_bits(u64 n)
-{
- return n & ((1ull << 48) - 1);
-}
-
/**
* upper_32_bits - return bits 32-63 of a number
* @n: the number we're accessing
diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h
index a4b1af581f69..248f4ac95642 100644
--- a/include/linux/t10-pi.h
+++ b/include/linux/t10-pi.h
@@ -59,6 +59,15 @@ struct crc64_pi_tuple {
__u8 ref_tag[6];
};
+/**
+ * lower_48_bits() - return bits 0-47 of a number
+ * @n: the number we're accessing
+ */
+static inline u64 lower_48_bits(u64 n)
+{
+ return n & ((1ull << 48) - 1);
+}
+
static inline u64 ext_pi_ref_tag(struct request *rq)
{
unsigned int shift = ilog2(queue_logical_block_size(rq->q));
--
2.17.2
On Sun, Mar 27, 2022 at 10:33 AM <[email protected]> wrote:
>
> The function is not generally applicable enough to be included in the core
> kernel header. Move it to block since it's the only subsystem using it.
Thanks.
Btw - replying on the list too, because at least last time you were on
the participants list, I got bounces about "mailbox too large".
WTH? Are you living in some hut in the wilderness in the good old
nineties using AOL for email?
Because admittedly the 21st century has been all that great so far,
but at least we got rid of mailbox limits.
Linus
On Sun, Mar 27, 2022 at 10:53 AM Linus Torvalds
<[email protected]> wrote:
>
> Because admittedly the 21st century has been all that great so far,
*hasn't
Duh.
Linus
On Sun, 27 Mar 2022 11:33:16 -0600, [email protected] wrote:
> From: Keith Busch <[email protected]>
>
> The function is not generally applicable enough to be included in the core
> kernel header. Move it to block since it's the only subsystem using it.
>
>
Applied, thanks!
[1/1] block: move lower_48_bits() to block
commit: 868e6139c5212e7d9de8332806aacfeafb349320
Best regards,
--
Jens Axboe