2022-04-15 00:44:20

by Satya Priya

Subject: [PATCH V10 8/9] arm64: dts: qcom: pm8008: Add base dts file

Add base DTS file for pm8008.

Signed-off-by: Satya Priya <[email protected]>
---
Changes in V9:
- Add single dt file for pm8008 instead of adding files like in V8.

Changes in V10:
- Add regulators under pm8008@8 i.e main mfd node.

arch/arm64/boot/dts/qcom/pm8008.dtsi | 42 ++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
new file mode 100644
index 0000000..7b4fe68
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2022, The Linux Foundation. All rights reserved.
+
+&pm8008_bus {
+ pm8008: pmic@8 {
+ compatible = "qcom,pm8008";
+ reg = <0x8>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #interrupt-cells = <2>;
+
+ pm8008_regulators: regulators {
+ pm8008_l1: ldo1 {
+ regulator-name = "pm8008_l1";
+ };
+
+ pm8008_l2: ldo2 {
+ regulator-name = "pm8008_l2";
+ };
+
+ pm8008_l3: ldo3 {
+ regulator-name = "pm8008_l3";
+ };
+
+ pm8008_l4: ldo4 {
+ regulator-name = "pm8008_l4";
+ };
+
+ pm8008_l5: ldo5 {
+ regulator-name = "pm8008_l5";
+ };
+
+ pm8008_l6: ldo6 {
+ regulator-name = "pm8008_l6";
+ };
+
+ pm8008_l7: ldo7 {
+ regulator-name = "pm8008_l7";
+ };
+ };
+ };
+};
--
2.7.4

2022-04-16 01:15:02

by Stephen Boyd

Subject: Re: [PATCH V10 8/9] arm64: dts: qcom: pm8008: Add base dts file

Quoting Satya Priya (2022-04-14 05:30:17)
> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
> new file mode 100644
> index 0000000..7b4fe68
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
> @@ -0,0 +1,42 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +// Copyright (c) 2022, The Linux Foundation. All rights reserved.
> +
> +&pm8008_bus {
> + pm8008: pmic@8 {
> + compatible = "qcom,pm8008";
> + reg = <0x8>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #interrupt-cells = <2>;
> +
> + pm8008_regulators: regulators {

Container nodes without a compatible string are frowned upon. How about
we add

compatible = "qcom,pm8008-regulators"

and then this can populated by the driver in the
devm_of_platform_populate() call that's already there.


> + pm8008_l1: ldo1 {
> + regulator-name = "pm8008_l1";
> + };
> +