Update machine driver startup, shutdown callback functions to avoid
sound card registration failure on other platforms.
Without this change, platforms with WCD codec is failing to register
sound card.
Fixes: c5198db82d4c ("ASoC: qcom: Add driver support for ALC5682I-VS")
Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Co-developed-by: Venkata Prasad Potturu <[email protected]>
Signed-off-by: Venkata Prasad Potturu <[email protected]>
---
Changes Since V1:
-- Update swith case in startup, shutdown callbacks for handling all dai id's
-- Update commit message and add Fixes tag
sound/soc/qcom/sc7280.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c
index 4ef4034..834c081 100644
--- a/sound/soc/qcom/sc7280.c
+++ b/sound/soc/qcom/sc7280.c
@@ -291,13 +291,7 @@ static void sc7280_snd_shutdown(struct snd_pcm_substream *substream)
SNDRV_PCM_STREAM_PLAYBACK);
}
break;
- case MI2S_SECONDARY:
- break;
- case LPASS_DP_RX:
- break;
default:
- dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
- cpu_dai->id);
break;
}
}
@@ -312,14 +306,8 @@ static int sc7280_snd_startup(struct snd_pcm_substream *substream)
case MI2S_PRIMARY:
ret = sc7280_rt5682_init(rtd);
break;
- case MI2S_SECONDARY:
- break;
- case LPASS_DP_RX:
- break;
default:
- dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
- cpu_dai->id);
- return -EINVAL;
+ break;
}
return ret;
}
--
2.7.4
On Tue, 19 Apr 2022 18:48:49 +0530, Srinivasa Rao Mandadapu wrote:
> Update machine driver startup, shutdown callback functions to avoid
> sound card registration failure on other platforms.
> Without this change, platforms with WCD codec is failing to register
> sound card.
>
> Fixes: c5198db82d4c ("ASoC: qcom: Add driver support for ALC5682I-VS")
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: SC7280: Update machine driver startup, shutdown callbacks
commit: c85f533d51ca42a461a61303322b0cf74fb75a6b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark