2022-04-05 02:06:53

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: msm8994: override nodes by label

Using node paths to extend or override a device tree node is error
prone. If there was a typo error, a new node will be created instead of
extending the existing node. This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time). This also reduces the indentation making the code
easier to read.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../dts/qcom/msm8994-huawei-angler-rev-101.dts | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
index 0e3dd48f0dbf..c1fb9a7d6fa4 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
@@ -27,15 +27,13 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+};

- soc {
- serial@f991e000 {
- status = "okay";
- pinctrl-names = "default", "sleep";
- pinctrl-0 = <&blsp1_uart2_default>;
- pinctrl-1 = <&blsp1_uart2_sleep>;
- };
- };
+&blsp1_uart2 {
+ status = "okay";
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&blsp1_uart2_default>;
+ pinctrl-1 = <&blsp1_uart2_sleep>;
};

&tlmm {
--
2.32.0

2022-04-05 02:11:58

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: msm8996: override nodes by label

Using node paths to extend or override a device tree node is error
prone. If there was a typo error, a new node will be created instead of
extending the existing node. This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time). This also reduces the indentation making the code
easier to read.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996-mtp.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-mtp.dts b/arch/arm64/boot/dts/qcom/msm8996-mtp.dts
index 6a1699a96c99..596ad4c896f5 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996-mtp.dts
@@ -18,12 +18,10 @@ aliases {
chosen {
stdout-path = "serial0";
};
+};

- soc {
- serial@75b0000 {
- status = "okay";
- };
- };
+&blsp2_uart2 {
+ status = "okay";
};

&hdmi {
--
2.32.0

2022-04-21 15:30:14

by Bjorn Andersson

Subject: Re: (subset) [PATCH 2/2] arm64: dts: qcom: msm8996: override nodes by label

On Sat, 2 Apr 2022 21:28:59 +0200, Krzysztof Kozlowski wrote:
> Using node paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time). This also reduces the indentation making the code
> easier to read.
>
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: msm8996: override nodes by label
commit: 2a80a66f68e37ce19dee7fdb3d3e946859712b53

Best regards,
--
Bjorn Andersson <[email protected]>

2022-04-22 21:49:30

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: msm8994: override nodes by label

On Sat, 2 Apr 2022 21:28:58 +0200, Krzysztof Kozlowski wrote:
> Using node paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time). This also reduces the indentation making the code
> easier to read.
>
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: msm8994: override nodes by label
commit: c46e3c4bdfaca1595b898bb58b112fd683fe0c11

Best regards,
--
Bjorn Andersson <[email protected]>