2022-04-24 13:21:10

by zgpeng

Subject: [PATCH] sched/fair: Fix decision matrix of type misfit_task

When the group type of the busiest is misfit_task, as
long as the type of the local group is not equal to
has_spare, those situation already filtered while
updating statistics.

Signed-off-by: zgpeng <[email protected]>
Reviewed-by: Samuel Liao <[email protected]>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d4bd299..b8c67e7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
* has_spare nr_idle balanced N/A N/A balanced balanced
* fully_busy nr_idle nr_idle N/A N/A balanced balanced
- * misfit_task force N/A N/A N/A force force
+ * misfit_task force N/A N/A N/A N/A N/A
* asym_packing force force N/A N/A force force
* imbalanced force force N/A N/A force force
* overloaded force force N/A N/A force avg_load
--
2.9.5

2022-04-25 18:58:30

by Dietmar Eggemann

Subject: Re: [PATCH] sched/fair: Fix decision matrix of type misfit_task

On 24/04/2022 09:56, zgpeng wrote:
> When the group type of the busiest is misfit_task, as
> long as the type of the local group is not equal to
> has_spare, those situation already filtered while
> updating statistics.
>
> Signed-off-by: zgpeng <[email protected]>
> Reviewed-by: Samuel Liao <[email protected]>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d4bd299..b8c67e7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
> * has_spare nr_idle balanced N/A N/A balanced balanced
> * fully_busy nr_idle nr_idle N/A N/A balanced balanced
> - * misfit_task force N/A N/A N/A force force
> + * misfit_task force N/A N/A N/A N/A N/A
> * asym_packing force force N/A N/A force force
> * imbalanced force force N/A N/A force force
> * overloaded force force N/A N/A force avg_load

This issue has been sorted. Patch from Tao Zhou <[email protected]> is
already on tip sched/core.

https://lkml.kernel.org/r/165062326028.4207.17060214721845047142.tip-bot2@tip-bot2