2022-04-27 09:31:56

by Liu Xinpeng

Subject: [PATCH v8 2/3] watchdog: wdat_wdt: Stop watchdog when rebooting the system

Executing reboot command several times on the machine "Dell
PowerEdge R740", UEFI security detection stopped machine
with the following prompt:

UEFI0082: The system was reset due to a timeout from the watchdog
timer. Check the System Event Log (SEL) or crash dumps from
Operating Sysstem to identify the source that triggered the
watchdog timer reset. Update the firmware or driver for the
identified device.

iDRAC has warning event: "The watchdog timer reset the system".

This patch fixes this issue by adding the reboot notifier.

Signed-off-by: Liu Xinpeng <[email protected]>
---
drivers/watchdog/wdat_wdt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
index df0865a61a70..6f36a653767b 100644
--- a/drivers/watchdog/wdat_wdt.c
+++ b/drivers/watchdog/wdat_wdt.c
@@ -462,6 +462,7 @@ static int wdat_wdt_probe(struct platform_device *pdev)
return ret;

watchdog_set_nowayout(&wdat->wdd, nowayout);
+ watchdog_stop_on_reboot(&wdat->wdd);
return devm_watchdog_register_device(dev, &wdat->wdd);
}

--
2.23.0

2022-04-27 09:51:37

by Guenter Roeck

Subject: Re: [PATCH v8 2/3] watchdog: wdat_wdt: Stop watchdog when rebooting the system

On Tue, Apr 26, 2022 at 10:53:29PM +0800, Liu Xinpeng wrote:
> Executing reboot command several times on the machine "Dell
> PowerEdge R740", UEFI security detection stopped machine
> with the following prompt:
>
> UEFI0082: The system was reset due to a timeout from the watchdog
> timer. Check the System Event Log (SEL) or crash dumps from
> Operating Sysstem to identify the source that triggered the
> watchdog timer reset. Update the firmware or driver for the
> identified device.
>
> iDRAC has warning event: "The watchdog timer reset the system".
>
> This patch fixes this issue by adding the reboot notifier.
>
> Signed-off-by: Liu Xinpeng <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/watchdog/wdat_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
> index df0865a61a70..6f36a653767b 100644
> --- a/drivers/watchdog/wdat_wdt.c
> +++ b/drivers/watchdog/wdat_wdt.c
> @@ -462,6 +462,7 @@ static int wdat_wdt_probe(struct platform_device *pdev)
> return ret;
>
> watchdog_set_nowayout(&wdat->wdd, nowayout);
> + watchdog_stop_on_reboot(&wdat->wdd);
> return devm_watchdog_register_device(dev, &wdat->wdd);
> }
>
> --
> 2.23.0
>