2022-04-16 01:45:53

by Aparna M

[permalink] [raw]
Subject: [RESEND PATCH v3] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0

From: Kishon Vijay Abraham I <[email protected]>

WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
This will enable the WiFi functionaliy on the board.

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
Signed-off-by: Vignesh Raghavendra <[email protected]>
Signed-off-by: Nikhil Devshatwar <[email protected]>
Signed-off-by: Aparna M <[email protected]>
---

v3 RESEND: rebased on top of v5.18-rc2
v2 -> v3: Use generic node names for the regulators as per DT Specs
v1 -> v2: Add "From" tag in commit message

arch/arm64/boot/dts/ti/k3-am642-sk.dts | 62 ++++++++++++++++++++++++++
1 file changed, 62 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index 1d7db8bf3a5c..59f506cbd275 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -125,6 +125,31 @@
vin-supply = <&vcc_3v3_sys>;
gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
};
+
+ com8_ls_en: regulator-1 {
+ compatible = "regulator-fixed";
+ regulator-name = "com8_ls_en";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ pinctrl-0 = <&main_com8_ls_en_pins_default>;
+ pinctrl-names = "default";
+ gpio = <&main_gpio0 62 GPIO_ACTIVE_LOW>;
+ };
+
+ wlan_en: regulator-2 {
+ /* output of SN74AVC4T245RSVR */
+ compatible = "regulator-fixed";
+ regulator-name = "wlan_en";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ enable-active-high;
+ pinctrl-0 = <&main_wlan_en_pins_default>;
+ pinctrl-names = "default";
+ vin-supply = <&com8_ls_en>;
+ gpio = <&main_gpio0 48 GPIO_ACTIVE_HIGH>;
+ };
};

&main_pmx0 {
@@ -216,6 +241,23 @@
AM64X_IOPAD(0x0270, PIN_INPUT, 0) /* (D18) ECAP0_IN_APWM_OUT */
>;
};
+ main_wlan_en_pins_default: main-wlan-en-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00c4, PIN_OUTPUT_PULLUP, 7) /* (V8) GPIO0_48 */
+ >;
+ };
+
+ main_com8_ls_en_pins_default: main-com8-ls-en-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00fc, PIN_OUTPUT, 7) /* (U7) PRG1_PRU0_GPO17.GPIO0_62 */
+ >;
+ };
+
+ main_wlan_pins_default: main-wlan-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00bc, PIN_INPUT, 7) /* (U8) GPIO0_46 */
+ >;
+ };
};

&mcu_uart0 {
@@ -293,6 +335,26 @@
status = "reserved";
};

+&sdhci0 {
+ vmmc-supply = <&wlan_en>;
+ bus-width = <4>;
+ non-removable;
+ cap-power-off-card;
+ keep-power-in-suspend;
+ ti,driver-strength-ohm = <50>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+ wlcore: wlcore@2 {
+ compatible = "ti,wl1837";
+ reg = <2>;
+ pinctrl-0 = <&main_wlan_pins_default>;
+ pinctrl-names = "default";
+ interrupt-parent = <&main_gpio0>;
+ interrupts = <46 IRQ_TYPE_EDGE_FALLING>;
+ };
+};
+
&sdhci1 {
/* SD/MMC */
vmmc-supply = <&vdd_mmc1>;
--
2.17.1


2022-04-22 17:34:18

by Bryan Brattlof

[permalink] [raw]
Subject: Re: [RESEND PATCH v3] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0

On April 14, 2022 thus sayeth Aparna M:
> From: Kishon Vijay Abraham I <[email protected]>
>
> WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
> This will enable the WiFi functionaliy on the board.
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> Signed-off-by: Vignesh Raghavendra <[email protected]>
> Signed-off-by: Nikhil Devshatwar <[email protected]>
> Signed-off-by: Aparna M <[email protected]>

Looks good to me!

Reviewed-by: Bryan Brattlof <[email protected]>

~Bryan

2022-04-27 15:45:53

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [RESEND PATCH v3] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0

Hi Aparna M,

On Thu, 14 Apr 2022 19:06:12 +0530, Aparna M wrote:
> From: Kishon Vijay Abraham I <[email protected]>
>
> WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
> This will enable the WiFi functionaliy on the board.
>
>

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0
commit: 065d62612e264e228c153afe9aa31d85aeea3d17

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh

2022-05-02 07:36:38

by Devarsh Thakkar

[permalink] [raw]
Subject: Re: [RESEND PATCH v3] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0


On 14/04/22 19:06, Aparna M wrote:
> From: Kishon Vijay Abraham I <[email protected]>
>
> WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
> This will enable the WiFi functionaliy on the board.
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> Signed-off-by: Vignesh Raghavendra <[email protected]>
> Signed-off-by: Nikhil Devshatwar <[email protected]>
> Signed-off-by: Aparna M <[email protected]>
Tested-by: Devarsh Thakkar <[email protected]>
> ---
>
> v3 RESEND: rebased on top of v5.18-rc2
> v2 -> v3: Use generic node names for the regulators as per DT Specs
> v1 -> v2: Add "From" tag in commit message
>
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 62 ++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 1d7db8bf3a5c..59f506cbd275 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -125,6 +125,31 @@
> vin-supply = <&vcc_3v3_sys>;
> gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
> };
> +
> + com8_ls_en: regulator-1 {
> + compatible = "regulator-fixed";
> + regulator-name = "com8_ls_en";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + pinctrl-0 = <&main_com8_ls_en_pins_default>;
> + pinctrl-names = "default";
> + gpio = <&main_gpio0 62 GPIO_ACTIVE_LOW>;
> + };
> +
> + wlan_en: regulator-2 {
> + /* output of SN74AVC4T245RSVR */
> + compatible = "regulator-fixed";
> + regulator-name = "wlan_en";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + enable-active-high;
> + pinctrl-0 = <&main_wlan_en_pins_default>;
> + pinctrl-names = "default";
> + vin-supply = <&com8_ls_en>;
> + gpio = <&main_gpio0 48 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &main_pmx0 {
> @@ -216,6 +241,23 @@
> AM64X_IOPAD(0x0270, PIN_INPUT, 0) /* (D18) ECAP0_IN_APWM_OUT */
> >;
> };
> + main_wlan_en_pins_default: main-wlan-en-pins-default {
> + pinctrl-single,pins = <
> + AM64X_IOPAD(0x00c4, PIN_OUTPUT_PULLUP, 7) /* (V8) GPIO0_48 */
> + >;
> + };
> +
> + main_com8_ls_en_pins_default: main-com8-ls-en-pins-default {
> + pinctrl-single,pins = <
> + AM64X_IOPAD(0x00fc, PIN_OUTPUT, 7) /* (U7) PRG1_PRU0_GPO17.GPIO0_62 */
> + >;
> + };
> +
> + main_wlan_pins_default: main-wlan-pins-default {
> + pinctrl-single,pins = <
> + AM64X_IOPAD(0x00bc, PIN_INPUT, 7) /* (U8) GPIO0_46 */
> + >;
> + };
> };
>
> &mcu_uart0 {
> @@ -293,6 +335,26 @@
> status = "reserved";
> };
>
> +&sdhci0 {
> + vmmc-supply = <&wlan_en>;
> + bus-width = <4>;
> + non-removable;
> + cap-power-off-card;
> + keep-power-in-suspend;
> + ti,driver-strength-ohm = <50>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + wlcore: wlcore@2 {
> + compatible = "ti,wl1837";
> + reg = <2>;
> + pinctrl-0 = <&main_wlan_pins_default>;
> + pinctrl-names = "default";
> + interrupt-parent = <&main_gpio0>;
> + interrupts = <46 IRQ_TYPE_EDGE_FALLING>;
> + };
> +};
> +
> &sdhci1 {
> /* SD/MMC */
> vmmc-supply = <&vdd_mmc1>;