2022-04-20 02:46:00

by Colin Ian King

Subject: [PATCH] PCI: versatile: Remove redundant variable retval

Variable retval is being assigned a value that is never read, the
variable is redundant and can be removed.

Cleans up clang scan build warning:
drivers/pci/controller/pci-versatile.c:37:10: warning: Although the value
stored to 'retval' is used in the enclosing expression, the value is never
actually read from 'retval' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/pci/controller/pci-versatile.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pci-versatile.c b/drivers/pci/controller/pci-versatile.c
index 653d5d0ecf81..7991d334e0f1 100644
--- a/drivers/pci/controller/pci-versatile.c
+++ b/drivers/pci/controller/pci-versatile.c
@@ -31,10 +31,9 @@ static u32 pci_slot_ignore;

static int __init versatile_pci_slot_ignore(char *str)
{
- int retval;
int slot;

- while ((retval = get_option(&str, &slot))) {
+ while (get_option(&str, &slot)) {
if ((slot < 0) || (slot > 31))
pr_err("Illegal slot value: %d\n", slot);
else
--
2.35.1

2022-04-29 14:06:42

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: versatile: Remove redundant variable retval

On Mon, 18 Apr 2022 15:44:16 +0100, Colin Ian King wrote:
> Variable retval is being assigned a value that is never read, the
> variable is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/pci/controller/pci-versatile.c:37:10: warning: Although the value
> stored to 'retval' is used in the enclosing expression, the value is never
> actually read from 'retval' [deadcode.DeadStores]
>
> [...]

Applied to pci/versatile, thanks!

[1/1] PCI: versatile: Remove redundant variable retval
https://git.kernel.org/lpieralisi/pci/c/6086987bde

Thanks,
Lorenzo