2022-04-22 17:38:52

by Tom Rix

Subject: [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

Smatch reports this issue
cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?

rk3399_cdn_dp is only used in cdn-dp-core.c so change
its storge-class specifier to static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index d3e6c93739bf..ce67c9daa2b1 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -48,7 +48,7 @@ struct cdn_dp_data {
u8 max_phy;
};

-struct cdn_dp_data rk3399_cdn_dp = {
+static struct cdn_dp_data rk3399_cdn_dp = {
.max_phy = 2,
};

--
2.27.0

2022-05-03 01:23:53

by Heiko Stuebner

Subject: Re: [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

On Thu, 21 Apr 2022 10:43:04 -0400, Tom Rix wrote:
> Smatch reports this issue
> cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?
>
> rk3399_cdn_dp is only used in cdn-dp-core.c so change
> its storge-class specifier to static.

Applied, thanks!

[1/1] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static
commit: 7494b1ed1df414e43dc8429f0c016b2054b1b5da

Best regards,
--
Heiko Stuebner <[email protected]>