2022-04-29 22:36:33

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH] dt-bindings: regulator: mt6315: Enforce regulator-compatible, not name

The MT6315 PMIC dt-binding should enforce that one of the valid
regulator-compatible is set in each regulator node. However it was
mistakenly matching against regulator-name instead.

Fix the typo. This not only fixes the compatible verification, but also
lifts the regulator-name restriction, so that more meaningful names can
be set for each platform.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

---

.../devicetree/bindings/regulator/mt6315-regulator.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
index 61dd5af80db6..5d2d989de893 100644
--- a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
@@ -31,7 +31,7 @@ properties:
$ref: "regulator.yaml#"

properties:
- regulator-name:
+ regulator-compatible:
pattern: "^vbuck[1-4]$"

additionalProperties: false
--
2.36.0


2022-05-05 16:58:27

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: mt6315: Enforce regulator-compatible, not name

On Fri, 29 Apr 2022 16:13:24 -0400, N?colas F. R. A. Prado wrote:
> The MT6315 PMIC dt-binding should enforce that one of the valid
> regulator-compatible is set in each regulator node. However it was
> mistakenly matching against regulator-name instead.
>
> Fix the typo. This not only fixes the compatible verification, but also
> lifts the regulator-name restriction, so that more meaningful names can
> be set for each platform.
>
> Signed-off-by: N?colas F. R. A. Prado <[email protected]>
>
> ---
>
> .../devicetree/bindings/regulator/mt6315-regulator.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2022-05-09 03:57:58

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: mt6315: Enforce regulator-compatible, not name

On Fri, 29 Apr 2022 16:13:24 -0400, Nícolas F. R. A. Prado wrote:
> The MT6315 PMIC dt-binding should enforce that one of the valid
> regulator-compatible is set in each regulator node. However it was
> mistakenly matching against regulator-name instead.
>
> Fix the typo. This not only fixes the compatible verification, but also
> lifts the regulator-name restriction, so that more meaningful names can
> be set for each platform.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] dt-bindings: regulator: mt6315: Enforce regulator-compatible, not name
commit: 6d435a94ba5bb4f2ad381c0828fbae89c66b50fe

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark