2022-05-17 07:33:53

by baihaowen

Subject: [PATCH] thermal: intel: hfi: remove null check after call container_of()

container_of() will never return NULL, so remove useless code.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/thermal/intel/intel_hfi.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
index 730fd121df6e..a0640f762dc5 100644
--- a/drivers/thermal/intel/intel_hfi.c
+++ b/drivers/thermal/intel/intel_hfi.c
@@ -243,8 +243,6 @@ static void hfi_update_work_fn(struct work_struct *work)

hfi_instance = container_of(to_delayed_work(work), struct hfi_instance,
update_work);
- if (!hfi_instance)
- return;

update_capabilities(hfi_instance);
}
--
2.7.4

2022-05-18 18:54:57

by Rafael J. Wysocki

Subject: Re: [PATCH] thermal: intel: hfi: remove null check after call container_of()

On Tue, May 17, 2022 at 3:31 AM Haowen Bai <[email protected]> wrote:
>
> container_of() will never return NULL, so remove useless code.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> drivers/thermal/intel/intel_hfi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
> index 730fd121df6e..a0640f762dc5 100644
> --- a/drivers/thermal/intel/intel_hfi.c
> +++ b/drivers/thermal/intel/intel_hfi.c
> @@ -243,8 +243,6 @@ static void hfi_update_work_fn(struct work_struct *work)
>
> hfi_instance = container_of(to_delayed_work(work), struct hfi_instance,
> update_work);
> - if (!hfi_instance)
> - return;
>
> update_capabilities(hfi_instance);
> }
> --

Applied with adjusted subject as 5.19 material, thanks!