Subject: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

Make ndo_open less sensitive to memory pressure.

Signed-off-by: Michael Trimarchi <[email protected]>
---
Change:
- Adjust the commit message addressing the comments in RFC version
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 9f33ec838b52..09eb6ea9a584 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
rxq = fep->rx_queue[queue];
bdp = rxq->bd.base;
for (i = 0; i < rxq->bd.ring_size; i++) {
- skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
+ skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
if (!skb)
goto err_alloc;

--
2.25.1



2022-05-19 12:39:48

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

On Wed, 18 May 2022 08:20:07 +0200 Michael Trimarchi wrote:
> Make ndo_open less sensitive to memory pressure.
>
> Signed-off-by: Michael Trimarchi <[email protected]>

Reviewed-by: Jakub Kicinski <[email protected]>

2022-05-19 16:48:17

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <[email protected]>:

On Wed, 18 May 2022 08:20:07 +0200 you wrote:
> Make ndo_open less sensitive to memory pressure.
>
> Signed-off-by: Michael Trimarchi <[email protected]>
> ---
> Change:
> - Adjust the commit message addressing the comments in RFC version
>
> [...]

Here is the summary with links:
- net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
https://git.kernel.org/netdev/net-next/c/b885aab3d39d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html