2022-04-07 15:23:37

by CGEL

[permalink] [raw]
Subject: [PATCH] powerpc/powernv: fix missing of_node_put in uv_init()

From: Lv Ruyi <[email protected]>

of_find_compatible_node() returns node pointer with refcount incremented,
use of_node_put() on it when done.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi <[email protected]>
---
arch/powerpc/platforms/powernv/ultravisor.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/powernv/ultravisor.c b/arch/powerpc/platforms/powernv/ultravisor.c
index e4a00ad06f9d..67c8c4b2d8b1 100644
--- a/arch/powerpc/platforms/powernv/ultravisor.c
+++ b/arch/powerpc/platforms/powernv/ultravisor.c
@@ -55,6 +55,7 @@ static int __init uv_init(void)
return -ENODEV;

uv_memcons = memcons_init(node, "memcons");
+ of_node_put(node);
if (!uv_memcons)
return -ENOENT;

--
2.25.1


2022-05-25 16:05:07

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc/powernv: fix missing of_node_put in uv_init()

On Thu, 7 Apr 2022 09:00:43 +0000, [email protected] wrote:
> From: Lv Ruyi <[email protected]>
>
> of_find_compatible_node() returns node pointer with refcount incremented,
> use of_node_put() on it when done.
>
>

Applied to powerpc/next.

[1/1] powerpc/powernv: fix missing of_node_put in uv_init()
https://git.kernel.org/powerpc/c/3ffa9fd471f57f365bc54fc87824c530422f64a5

cheers