2022-05-25 01:00:35

by Min Li

Subject: [PATCH net v2] ptp: ptp_clockmatrix: fix is_single_shot

is_single_shot should return false for the power_of_2 mask

Fixes: b95fcd0e776f ("ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support")
Signed-off-by: Min Li <[email protected]>
---
-Add Fixes tag

drivers/ptp/ptp_clockmatrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index cb258e1..c9d451b 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -267,7 +267,7 @@ static int arm_tod_read_trig_sel_refclk(struct idtcm_channel *channel, u8 ref)
static bool is_single_shot(u8 mask)
{
/* Treat single bit ToD masks as continuous trigger */
- return mask <= 8 && is_power_of_2(mask);
+ return !(mask <= 8 && is_power_of_2(mask));
}

static int idtcm_extts_enable(struct idtcm_channel *channel,
--
2.7.4

2022-05-28 19:28:23

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net v2] ptp: ptp_clockmatrix: fix is_single_shot

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 24 May 2022 10:45:01 -0400 you wrote:
> is_single_shot should return false for the power_of_2 mask
>
> Fixes: b95fcd0e776f ("ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support")
> Signed-off-by: Min Li <[email protected]>
> ---
> -Add Fixes tag
>
> [...]

Here is the summary with links:
- [net,v2] ptp: ptp_clockmatrix: fix is_single_shot
https://git.kernel.org/netdev/net/c/d0bbe0328fe5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html