2022-05-28 19:13:25

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH] ASoC: qcom: lpass-platform: Update VMA access permissions in mmap callback

Replace page protection permissions from noncashed to writecombine,
in lpass codec DMA path mmp callabck, to support 64 bit chromeOS.
Avoid SIGBUS error in userspace caused by noncached permissions in
64 bit chromeOS.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
index f03a7ae..b41ab7a 100644
--- a/sound/soc/qcom/lpass-platform.c
+++ b/sound/soc/qcom/lpass-platform.c
@@ -898,7 +898,7 @@ static int lpass_platform_cdc_dma_mmap(struct snd_pcm_substream *substream,
struct snd_pcm_runtime *runtime = substream->runtime;
unsigned long size, offset;

- vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
+ vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
size = vma->vm_end - vma->vm_start;
offset = vma->vm_pgoff << PAGE_SHIFT;
return io_remap_pfn_range(vma, vma->vm_start,
--
2.7.4



2022-06-01 19:27:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: qcom: lpass-platform: Update VMA access permissions in mmap callback

On Fri, 27 May 2022 19:40:08 +0530, Srinivasa Rao Mandadapu wrote:
> Replace page protection permissions from noncashed to writecombine,
> in lpass codec DMA path mmp callabck, to support 64 bit chromeOS.
> Avoid SIGBUS error in userspace caused by noncached permissions in
> 64 bit chromeOS.
>
>

Applied to

broonie/sound.git for-linus

Thanks!

[1/1] ASoC: qcom: lpass-platform: Update VMA access permissions in mmap callback
commit: ef8d89b83bf453ea9cc3c4873a84b50ff334f797

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark