2022-06-05 12:05:46

by Miaoqian Lin

Subject: [PATCH] net: dsa: lantiq_gswip: Fix refcount leak in gswip_gphy_fw_list

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node.
when breaking early from a for_each_available_child_of_node() loop,
we need to explicitly call of_node_put() on the gphy_fw_np.
Add missing of_node_put() to avoid refcount leak.

Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/net/dsa/lantiq_gswip.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 8af4def38a98..e531b93f3cb2 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -2070,8 +2070,10 @@ static int gswip_gphy_fw_list(struct gswip_priv *priv,
for_each_available_child_of_node(gphy_fw_list_np, gphy_fw_np) {
err = gswip_gphy_fw_probe(priv, &priv->gphy_fw[i],
gphy_fw_np, i);
- if (err)
+ if (err) {
+ of_node_put(gphy_fw_np);
goto remove_gphy;
+ }
i++;
}

--
2.25.1

2022-06-08 08:51:53

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: dsa: lantiq_gswip: Fix refcount leak in gswip_gphy_fw_list

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Sun, 5 Jun 2022 11:23:34 +0400 you wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node.
> when breaking early from a for_each_available_child_of_node() loop,
> we need to explicitly call of_node_put() on the gphy_fw_np.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Miaoqian Lin <[email protected]>
>
> [...]

Here is the summary with links:
- net: dsa: lantiq_gswip: Fix refcount leak in gswip_gphy_fw_list
https://git.kernel.org/netdev/net/c/0737e018a05e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html