2022-06-21 08:56:43

by Jiang Jian

Subject: [PATCH] net: ipa: remove unexpected word "the"

there is an unexpected word "the" in the comments that need to be removed

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/net/ipa/gsi_trans.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c
index cf646dc8e36a..29496ca15825 100644
--- a/drivers/net/ipa/gsi_trans.c
+++ b/drivers/net/ipa/gsi_trans.c
@@ -339,7 +339,7 @@ struct gsi_trans *gsi_channel_trans_alloc(struct gsi *gsi, u32 channel_id,
if (!gsi_trans_tre_reserve(trans_info, tre_count))
return NULL;

- /* Allocate and initialize non-zero fields in the the transaction */
+ /* Allocate and initialize non-zero fields in the transaction */
trans = gsi_trans_pool_alloc(&trans_info->pool, 1);
trans->gsi = gsi;
trans->channel_id = channel_id;
@@ -669,7 +669,7 @@ int gsi_trans_read_byte(struct gsi *gsi, u32 channel_id, dma_addr_t addr)
if (!gsi_trans_tre_reserve(trans_info, 1))
return -EBUSY;

- /* Now fill the the reserved TRE and tell the hardware */
+ /* Now fill the reserved TRE and tell the hardware */

dest_tre = gsi_ring_virt(tre_ring, tre_ring->index);
gsi_trans_tre_fill(dest_tre, addr, 1, true, false, IPA_CMD_NONE);
--
2.17.1

2022-06-21 14:35:41

by Alex Elder

Subject: Re: [PATCH] net: ipa: remove unexpected word "the"

On 6/21/22 3:50 AM, Jiang Jian wrote:
> there is an unexpected word "the" in the comments that need to be removed

In the future, maybe something more like "Remove duplicate 'the'
in two places."

But regardless, this looks fine to me.

Reviewed-by: Alex Elder <[email protected]>

>
> Signed-off-by: Jiang Jian <[email protected]>
> ---
> drivers/net/ipa/gsi_trans.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c
> index cf646dc8e36a..29496ca15825 100644
> --- a/drivers/net/ipa/gsi_trans.c
> +++ b/drivers/net/ipa/gsi_trans.c
> @@ -339,7 +339,7 @@ struct gsi_trans *gsi_channel_trans_alloc(struct gsi *gsi, u32 channel_id,
> if (!gsi_trans_tre_reserve(trans_info, tre_count))
> return NULL;
>
> - /* Allocate and initialize non-zero fields in the the transaction */
> + /* Allocate and initialize non-zero fields in the transaction */
> trans = gsi_trans_pool_alloc(&trans_info->pool, 1);
> trans->gsi = gsi;
> trans->channel_id = channel_id;
> @@ -669,7 +669,7 @@ int gsi_trans_read_byte(struct gsi *gsi, u32 channel_id, dma_addr_t addr)
> if (!gsi_trans_tre_reserve(trans_info, 1))
> return -EBUSY;
>
> - /* Now fill the the reserved TRE and tell the hardware */
> + /* Now fill the reserved TRE and tell the hardware */
>
> dest_tre = gsi_ring_virt(tre_ring, tre_ring->index);
> gsi_trans_tre_fill(dest_tre, addr, 1, true, false, IPA_CMD_NONE);

2022-06-23 01:42:58

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ipa: remove unexpected word "the"

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 21 Jun 2022 16:50:01 +0800 you wrote:
> there is an unexpected word "the" in the comments that need to be removed
>
> Signed-off-by: Jiang Jian <[email protected]>
> ---
> drivers/net/ipa/gsi_trans.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- net: ipa: remove unexpected word "the"
https://git.kernel.org/netdev/net-next/c/7c0d97e4b696

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html