2022-06-22 12:58:02

by Michael Walle

Subject: [PATCH net-next 0/2] net: use new hwmon_sanitize_name()

These are the remaining patches of my former series [1] which were hold
back because it would have required a stable branch between the subsystems.

[1] https://lore.kernel.org/r/[email protected]/

Michael Walle (2):
net: sfp: use hwmon_sanitize_name()
net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()

drivers/net/phy/nxp-tja11xx.c | 11 +++--------
drivers/net/phy/sfp.c | 10 +++-------
2 files changed, 6 insertions(+), 15 deletions(-)

--
2.30.2

2022-06-22 13:09:35

by Michael Walle

Subject: [PATCH net-next 2/2] net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()

Instead of open-coding the bad characters replacement in the hwmon name,
use the new devm_hwmon_sanitize_name().

Signed-off-by: Michael Walle <[email protected]>
---
drivers/net/phy/nxp-tja11xx.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c
index 9944cc501806..2a8195c50d14 100644
--- a/drivers/net/phy/nxp-tja11xx.c
+++ b/drivers/net/phy/nxp-tja11xx.c
@@ -444,15 +444,10 @@ static int tja11xx_hwmon_register(struct phy_device *phydev,
struct tja11xx_priv *priv)
{
struct device *dev = &phydev->mdio.dev;
- int i;
-
- priv->hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
- if (!priv->hwmon_name)
- return -ENOMEM;

- for (i = 0; priv->hwmon_name[i]; i++)
- if (hwmon_is_bad_char(priv->hwmon_name[i]))
- priv->hwmon_name[i] = '_';
+ priv->hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
+ if (IS_ERR(priv->hwmon_name))
+ return PTR_ERR(priv->hwmon_name);

priv->hwmon_dev =
devm_hwmon_device_register_with_info(dev, priv->hwmon_name,
--
2.30.2

2022-06-22 15:32:55

by Guenter Roeck

Subject: Re: [PATCH net-next 2/2] net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()

On Wed, Jun 22, 2022 at 02:35:43PM +0200, Michael Walle wrote:
> Instead of open-coding the bad characters replacement in the hwmon name,
> use the new devm_hwmon_sanitize_name().
>
> Signed-off-by: Michael Walle <[email protected]>

Acked-by: Guenter Roeck <[email protected]>

> ---
> drivers/net/phy/nxp-tja11xx.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c
> index 9944cc501806..2a8195c50d14 100644
> --- a/drivers/net/phy/nxp-tja11xx.c
> +++ b/drivers/net/phy/nxp-tja11xx.c
> @@ -444,15 +444,10 @@ static int tja11xx_hwmon_register(struct phy_device *phydev,
> struct tja11xx_priv *priv)
> {
> struct device *dev = &phydev->mdio.dev;
> - int i;
> -
> - priv->hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
> - if (!priv->hwmon_name)
> - return -ENOMEM;
>
> - for (i = 0; priv->hwmon_name[i]; i++)
> - if (hwmon_is_bad_char(priv->hwmon_name[i]))
> - priv->hwmon_name[i] = '_';
> + priv->hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
> + if (IS_ERR(priv->hwmon_name))
> + return PTR_ERR(priv->hwmon_name);
>
> priv->hwmon_dev =
> devm_hwmon_device_register_with_info(dev, priv->hwmon_name,
> --
> 2.30.2
>

2022-06-24 04:20:44

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next 0/2] net: use new hwmon_sanitize_name()

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 22 Jun 2022 14:35:41 +0200 you wrote:
> These are the remaining patches of my former series [1] which were hold
> back because it would have required a stable branch between the subsystems.
>
> [1] https://lore.kernel.org/r/[email protected]/
>
> Michael Walle (2):
> net: sfp: use hwmon_sanitize_name()
> net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()
>
> [...]

Here is the summary with links:
- [net-next,1/2] net: sfp: use hwmon_sanitize_name()
https://git.kernel.org/netdev/net-next/c/3f118c449c8e
- [net-next,2/2] net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()
https://git.kernel.org/netdev/net-next/c/363b65459b78

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html