2022-05-18 03:42:09

by Luca Weiss

Subject: [PATCH] ARM: dts: qcom: msm8974: Add BAM DMUX Ethernet/IP device

BAM DMUX is used as the network interface to the modem.

Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 814ad0b46232..ffa6f874917a 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1146,6 +1146,18 @@ spmi_bus: spmi@fc4cf000 {
#interrupt-cells = <4>;
};

+ bam_dmux_dma: dma-controller@fc834000 {
+ compatible = "qcom,bam-v1.4.0";
+ reg = <0xfc834000 0x7000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+
+ num-channels = <6>;
+ qcom,num-ees = <1>;
+ qcom,powered-remotely;
+ };
+
remoteproc_mss: remoteproc@fc880000 {
compatible = "qcom,msm8974-mss-pil";
reg = <0xfc880000 0x100>, <0xfc820000 0x020>;
@@ -1180,6 +1192,20 @@ mpss {
memory-region = <&mpss_region>;
};

+ bam_dmux: bam-dmux {
+ compatible = "qcom,bam-dmux";
+
+ interrupt-parent = <&modem_smsm>;
+ interrupts = <1 IRQ_TYPE_EDGE_BOTH>, <11 IRQ_TYPE_EDGE_BOTH>;
+ interrupt-names = "pc", "pc-ack";
+
+ qcom,smem-states = <&apps_smsm 1>, <&apps_smsm 11>;
+ qcom,smem-state-names = "pc", "pc-ack";
+
+ dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>;
+ dma-names = "tx", "rx";
+ };
+
smd-edge {
interrupts = <GIC_SPI 25 IRQ_TYPE_EDGE_RISING>;

--
2.36.0

2022-05-18 18:11:15

by Stephan Gerhold

Subject: Re: [PATCH] ARM: dts: qcom: msm8974: Add BAM DMUX Ethernet/IP device

On Tue, May 17, 2022 at 10:34:51PM +0200, Luca Weiss wrote:
> BAM DMUX is used as the network interface to the modem.
>
> Signed-off-by: Luca Weiss <[email protected]>

Thanks for sending this patch!

Reviewed-by: Stephan Gerhold <[email protected]>

> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 814ad0b46232..ffa6f874917a 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1146,6 +1146,18 @@ spmi_bus: spmi@fc4cf000 {
> #interrupt-cells = <4>;
> };
>
> + bam_dmux_dma: dma-controller@fc834000 {
> + compatible = "qcom,bam-v1.4.0";
> + reg = <0xfc834000 0x7000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + qcom,ee = <0>;
> +
> + num-channels = <6>;
> + qcom,num-ees = <1>;
> + qcom,powered-remotely;
> + };
> +
> remoteproc_mss: remoteproc@fc880000 {
> compatible = "qcom,msm8974-mss-pil";
> reg = <0xfc880000 0x100>, <0xfc820000 0x020>;
> @@ -1180,6 +1192,20 @@ mpss {
> memory-region = <&mpss_region>;
> };
>
> + bam_dmux: bam-dmux {
> + compatible = "qcom,bam-dmux";
> +
> + interrupt-parent = <&modem_smsm>;
> + interrupts = <1 IRQ_TYPE_EDGE_BOTH>, <11 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "pc", "pc-ack";
> +
> + qcom,smem-states = <&apps_smsm 1>, <&apps_smsm 11>;
> + qcom,smem-state-names = "pc", "pc-ack";
> +
> + dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>;
> + dma-names = "tx", "rx";
> + };
> +
> smd-edge {
> interrupts = <GIC_SPI 25 IRQ_TYPE_EDGE_RISING>;
>
> --
> 2.36.0
>

2022-07-03 04:45:54

by Bjorn Andersson

Subject: Re: (subset) [PATCH] ARM: dts: qcom: msm8974: Add BAM DMUX Ethernet/IP device

On Tue, 17 May 2022 22:34:51 +0200, Luca Weiss wrote:
> BAM DMUX is used as the network interface to the modem.
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: msm8974: Add BAM DMUX Ethernet/IP device
commit: 4eb1560259de4fd5f89ec5e7faf5d4c6a83bae9c

Best regards,
--
Bjorn Andersson <[email protected]>