2022-07-13 07:50:22

by Sebin Sebastian

Subject: [PATCH -next] octeontx2-af: returning uninitialized variable

Fix coverity error 'use of uninitialized variable'. err is uninitialized
and is returned which can lead to unintended results. err has been replaced
with -einval.
Coverity issue: 1518921 (uninitialized scalar variable)

Signed-off-by: Sebin Sebastian <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
index ed8b9afbf731..563bf1497fd0 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
@@ -1961,7 +1961,7 @@ int rvu_npc_exact_init(struct rvu *rvu)
dev_err(rvu->dev,
"%s: failed to set drop info for cgx=%d, lmac=%d, chan=%llx\n",
__func__, cgx_id, lmac_id, chan_val);
- return err;
+ return -EINVAL;
}

err = npc_install_mcam_drop_rule(rvu, *drop_mcam_idx,
--
2.34.1

2022-07-13 14:09:08

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] octeontx2-af: returning uninitialized variable

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Wed, 13 Jul 2022 13:08:58 +0530 you wrote:
> Fix coverity error 'use of uninitialized variable'. err is uninitialized
> and is returned which can lead to unintended results. err has been replaced
> with -einval.
> Coverity issue: 1518921 (uninitialized scalar variable)
>
> Signed-off-by: Sebin Sebastian <[email protected]>
>
> [...]

Here is the summary with links:
- [-next] octeontx2-af: returning uninitialized variable
https://git.kernel.org/netdev/net-next/c/6a605eb1d71e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html