2022-04-11 22:55:55

by CGEL

Subject: [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

From: Minghao Chi <[email protected]>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/remoteproc/keystone_remoteproc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
index 54781f553f4e..594a9b43b7ae 100644
--- a/drivers/remoteproc/keystone_remoteproc.c
+++ b/drivers/remoteproc/keystone_remoteproc.c
@@ -410,10 +410,9 @@ static int keystone_rproc_probe(struct platform_device *pdev)

/* enable clock for accessing DSP internal memories */
pm_runtime_enable(dev);
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
dev_err(dev, "failed to enable clock, status = %d\n", ret);
- pm_runtime_put_noidle(dev);
goto disable_rpm;
}

--
2.25.1

2022-07-18 23:00:51

by Bjorn Andersson

Subject: Re: (subset) [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

On Mon, 11 Apr 2022 01:36:56 +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
>

Applied, thanks!

[1/1] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
commit: 3ebebb9a2d9a5c2d2b866739b50838dc152727fc

Best regards,
--
Bjorn Andersson <[email protected]>