2022-06-08 03:57:11

by Xuezhi Zhang

[permalink] [raw]
Subject: [PATCH] rpmsg: convert sysfs snprintf to sysfs_emit

Fix the following coccicheck warning:
drivers/rpmsg/qcom_glink_native.c:1677:8-16:
WARNING: use scnprintf or sprintf

Signed-off-by: Xuezhi Zhang <[email protected]>
---
drivers/rpmsg/qcom_glink_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 07586514991f..62e741883222 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1674,7 +1674,7 @@ static ssize_t rpmsg_name_show(struct device *dev,
if (ret < 0)
name = dev->of_node->name;

- return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", name);
+ return sysfs_emit(buf, "%s\n", name);
}
static DEVICE_ATTR_RO(rpmsg_name);

--
2.34.1


2022-07-18 23:17:26

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH] rpmsg: convert sysfs snprintf to sysfs_emit

On Tue, 7 Jun 2022 20:06:49 +0800, Xuezhi Zhang wrote:
> Fix the following coccicheck warning:
> drivers/rpmsg/qcom_glink_native.c:1677:8-16:
> WARNING: use scnprintf or sprintf
>
>

Applied, thanks!

[1/1] rpmsg: convert sysfs snprintf to sysfs_emit
commit: 7113ac825371c17c15e2d0be79d850e5e16d3328

Best regards,
--
Bjorn Andersson <[email protected]>