2022-07-14 08:12:12

by Yang Li

Subject: [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error

Signed-off-by: Yang Li <[email protected]>
---
drivers/soc/qcom/icc-bwmon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index bea3ea1de7a4..7f8aca533cd3 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev)
}

bwmon->irq = platform_get_irq(pdev, 0);
- if (bwmon->irq < 0) {
- dev_err(dev, "failed to acquire bwmon IRQ\n");
+ if (bwmon->irq < 0)
return bwmon->irq;
- }

ret = devm_pm_opp_of_add_table(dev);
if (ret)
--
2.20.1.7.g153144c

2022-07-14 09:11:08

by Krzysztof Kozlowski

Subject: Re: [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

On 14/07/2022 09:55, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
>
> Signed-off-by: Yang Li <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-07-19 04:50:40

by Bjorn Andersson

Subject: Re: (subset) [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

On Thu, 14 Jul 2022 15:55:32 +0800, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
>
>

Applied, thanks!

[1/1] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
commit: 947bb0d16576bdac27f3355f268f51acfe29bfa7

Best regards,
--
Bjorn Andersson <[email protected]>