2022-07-16 02:05:20

by Wang Jingjin

Subject: [PATCH -next] drm/vc4: Add explicit declaration of 'drmm_of_get_bridge'

Fix the error of implicit declaration of function 'drmm_of_get_bridge':

drivers/gpu/drm/vc4/vc4_dpi.c:278:11: error: implicit declaration of function ‘drmm_of_get_bridge’; did you mean ‘devm_drm_of_get_bridge’? [-Werror=implicit-function-declaration]
bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0);

Fixes: 055af0235aef ("drm/vc4: dpi: Switch to drmm_of_get_bridge")
Signed-off-by: Wang Jingjin <[email protected]>
---
include/drm/drm_bridge.h | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index dba5d81e3b4a..6b65b0dfb4fb 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -959,6 +959,14 @@ static inline struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
{
return ERR_PTR(-ENODEV);
}
+
+static inline struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
+ struct device_node *node,
+ u32 port,
+ u32 endpoint)
+{
+ return ERR_PTR(-ENODEV);
+}
#endif

#endif
--
2.25.1

2022-07-21 10:45:51

by Maxime Ripard

Subject: Re: (subset) [PATCH -next] drm/vc4: Add explicit declaration of 'drmm_of_get_bridge'

On Sat, 16 Jul 2022 10:07:41 +0800, Wang Jingjin wrote:
> Fix the error of implicit declaration of function 'drmm_of_get_bridge':
>
> drivers/gpu/drm/vc4/vc4_dpi.c:278:11: error: implicit declaration of function ‘drmm_of_get_bridge’; did you mean ‘devm_drm_of_get_bridge’? [-Werror=implicit-function-declaration]
> bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0);
>
>

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime