2022-07-21 06:44:38

by Venkata Prasad Potturu

[permalink] [raw]
Subject: [PATCH 1/5] ASoC: amd: acp: Modify local variables name to generic

Change local variables name to be generic in irq handler.

Signed-off-by: Venkata Prasad Potturu <[email protected]>
Reviewed-by: Vijendar Mukunda <[email protected]>
---
sound/soc/amd/acp/acp-platform.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 327e17736dbd..b1ca52274375 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -94,19 +94,19 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
struct acp_resource *rsrc = adata->rsrc;
struct acp_stream *stream;
u16 i2s_flag = 0;
- u32 val, val1, i;
+ u32 ext_intr_stat, ext_intr_stat1, i;

if (!adata)
return IRQ_NONE;

if (adata->rsrc->no_of_ctrls == 2)
- val1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
+ ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));

- val = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
+ ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));

for (i = 0; i < ACP_MAX_STREAM; i++) {
stream = adata->stream[i];
- if (stream && (val & stream->irq_bit)) {
+ if (stream && (ext_intr_stat & stream->irq_bit)) {
writel(stream->irq_bit,
ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
snd_pcm_period_elapsed(stream->substream);
@@ -114,7 +114,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
break;
}
if (adata->rsrc->no_of_ctrls == 2) {
- if (stream && (val1 & stream->irq_bit)) {
+ if (stream && (ext_intr_stat1 & stream->irq_bit)) {
writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata,
(rsrc->irqp_used - 1)));
snd_pcm_period_elapsed(stream->substream);
--
2.25.1


2022-07-22 13:18:55

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/5] ASoC: amd: acp: Modify local variables name to generic

On Thu, 21 Jul 2022 11:50:33 +0530, Venkata Prasad Potturu wrote:
> Change local variables name to be generic in irq handler.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: amd: acp: Modify local variables name to generic
commit: 93f53881473cbf6a364be36ccbb99568e04ffe59
[2/5] ASoC: amd: acp: Drop superfluous mmap callback
commit: afde6727a9b66ff96e20d74ac392f3efdae1ceaf
[3/5] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open
(no commit info)
[4/5] ASoC: amd: acp: Modify const resource struct variable to generic
commit: 96b008a1c2e9f455d982e9cfb7117a3a0fc8f550
[5/5] ASoC: amd: acp: Add error handling cases
commit: c49f5e74a11e3909c424cada0f5d52345084933f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark