2022-07-27 15:15:10

by Li Qiong

Subject: [PATCH] net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug()

If 'local_odp_mr->r_trans_private' is a error code,
it is better to print the error code than to print
the value of IS_ERR().

Signed-off-by: Li Qiong <[email protected]>
---
net/rds/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 6f1a50d50d06..fba82d36593a 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -742,7 +742,7 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
NULL, 0, rs, &local_odp_mr->r_key, NULL,
iov->addr, iov->bytes, ODP_VIRTUAL);
if (IS_ERR(local_odp_mr->r_trans_private)) {
- ret = IS_ERR(local_odp_mr->r_trans_private);
+ ret = PTR_ERR(local_odp_mr->r_trans_private);
rdsdebug("get_mr ret %d %p\"", ret,
local_odp_mr->r_trans_private);
kfree(local_odp_mr);
--
2.11.0

2022-08-01 10:55:08

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Wed, 27 Jul 2022 23:03:41 +0800 you wrote:
> If 'local_odp_mr->r_trans_private' is a error code,
> it is better to print the error code than to print
> the value of IS_ERR().
>
> Signed-off-by: Li Qiong <[email protected]>
> ---
> net/rds/rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net/rds: Use PTR_ERR instead of IS_ERR for rdsdebug()
https://git.kernel.org/netdev/net/c/5121db6afb99

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html