2022-08-02 02:00:33

by Kiwoong Kim

Subject: [PATCH v2] scsi: ufs: enable link lost interrupt

v1 -> v2: add a fixes tag

Link lost is treated as fatal error with the patch
c99b9b2, but its event isn't registered as interrupt source,
so I enable it.

Fixes: c99b9b2 ("scsi: ufs: Treat link loss as fatal error")
Signed-off-by: Kiwoong Kim <[email protected]>
---
drivers/scsi/ufs/ufshci.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index a7ff0e5..0b627f4 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -133,11 +133,7 @@ static inline u32 ufshci_version(u32 major, u32 minor)

#define UFSHCD_UIC_MASK (UIC_COMMAND_COMPL | UFSHCD_UIC_PWR_MASK)

-#define UFSHCD_ERROR_MASK (UIC_ERROR |\
- DEVICE_FATAL_ERROR |\
- CONTROLLER_FATAL_ERROR |\
- SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+#define UFSHCD_ERROR_MASK (UIC_ERROR | INT_FATAL_ERRORS)

#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
--
2.7.4

2022-08-02 17:49:18

by Bart Van Assche

Subject: Re: [PATCH v2] scsi: ufs: enable link lost interrupt

On 8/1/22 18:42, Kiwoong Kim wrote:
> Link lost is treated as fatal error with the patch
> c99b9b2, but its event isn't registered as interrupt source,
> so I enable it.

Reviewed-by: Bart Van Assche <[email protected]>

2022-08-12 02:41:43

by Martin K. Petersen

Subject: Re: [PATCH v2] scsi: ufs: enable link lost interrupt

Kiwoong,

> v1 -> v2: add a fixes tag

Version commentary needs to go after the patch description separated by
a triple dash.

> Link lost is treated as fatal error with the patch c99b9b2

Commit hashes need to be 12 characters long.

I fixed these up and applied to 5.20/scsi-staging.

--
Martin K. Petersen Oracle Linux Engineering