2022-07-28 10:07:18

by Zeng Jingxiang

Subject: [PATCH v2] rtc: rtc-spear: set range max

From: Zeng Jingxiang <[email protected]>

In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
("rtc: spear: set range"), the value of
RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;

Fixes: f395e1d3b28d ("rtc: spear: set range")
Signed-off-by: Zeng Jingxiang <[email protected]>
---

Change in v2:
- Add fixes tag

drivers/rtc/rtc-spear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index d4777b01ab22..736fe535cd45 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)

config->rtc->ops = &spear_rtc_ops;
config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
- config->rtc->range_min = RTC_TIMESTAMP_END_9999;
+ config->rtc->range_max = RTC_TIMESTAMP_END_9999;

status = devm_rtc_register_device(config->rtc);
if (status)
--
2.27.0

2022-07-28 10:58:18

by Viresh Kumar

Subject: Re: [PATCH v2] rtc: rtc-spear: set range max

On 28-07-22, 18:01, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <[email protected]>
>
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> Fixes: f395e1d3b28d ("rtc: spear: set range")
> Signed-off-by: Zeng Jingxiang <[email protected]>

Acked-by: Viresh Kumar <[email protected]>

> ---
>
> Change in v2:
> - Add fixes tag
>
> drivers/rtc/rtc-spear.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index d4777b01ab22..736fe535cd45 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
>
> config->rtc->ops = &spear_rtc_ops;
> config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> - config->rtc->range_min = RTC_TIMESTAMP_END_9999;
> + config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> status = devm_rtc_register_device(config->rtc);
> if (status)
> --
> 2.27.0

--
viresh

2022-08-09 12:19:35

by Alexandre Belloni

Subject: Re: [PATCH v2] rtc: rtc-spear: set range max

On Thu, 28 Jul 2022 18:01:01 +0800, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <[email protected]>
>
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> [...]

Applied, thanks!

[1/1] rtc: rtc-spear: set range max
commit: 03c4cd6f89e074a51e289eb9129ac646f0f2bd29

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com