2022-07-23 08:39:17

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: soc: qcom: smd: reference SMD edge schema

The child node of smd is an SMD edge representing remote subsystem.
Bring back missing reference from previously sent patch (disappeared
when applying).

Link: https://lore.kernel.org/r/[email protected]
Fixes: 385fad1303af ("dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
index 62bebb5f83bc..9b3efe97f47c 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
@@ -21,7 +21,7 @@ properties:

patternProperties:
"^.*-edge|rpm$":
- type: object
+ $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
description:
Each subnode of the SMD node represents a remote subsystem or a remote
processor of some sort - or in SMD language an "edge". The name of the
--
2.34.1


2022-07-23 08:57:50

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: soc: qcom: smd-rpm: extend example

Replace existing limited example with proper code for Qualcomm Resource
Power Manager (RPM) over SMD based on MSM8916. This also fixes the
example's indentation.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/soc/qcom/qcom,smd-rpm.yaml | 33 +++++++++++++++----
1 file changed, 27 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
index 50f834563e19..09d5bfa920f2 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
@@ -92,12 +92,33 @@ examples:
qcom,ipc = <&apcs 8 0>;
qcom,smd-edge = <15>;

- rpm-requests {
- compatible = "qcom,rpm-msm8974";
- qcom,smd-channels = "rpm_requests";
+ rpm-requests {
+ compatible = "qcom,rpm-msm8916";
+ qcom,smd-channels = "rpm_requests";
+
+ clock-controller {
+ compatible = "qcom,rpmcc-msm8916", "qcom,rpmcc";
+ #clock-cells = <1>;
+ clocks = <&xo_board>;
+ clock-names = "xo";
+ };

- /* Regulator nodes to follow */
+ power-controller {
+ compatible = "qcom,msm8916-rpmpd";
+ #power-domain-cells = <1>;
+ operating-points-v2 = <&rpmpd_opp_table>;
+
+ rpmpd_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-1 {
+ opp-level = <1>;
+ };
+ opp-2 {
+ opp-level = <2>;
+ };
+ };
};
};
- };
-...
+ };
+ };
--
2.34.1

2022-07-25 19:28:25

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: smd: reference SMD edge schema

On Sat, 23 Jul 2022 10:23:57 +0200, Krzysztof Kozlowski wrote:
> The child node of smd is an SMD edge representing remote subsystem.
> Bring back missing reference from previously sent patch (disappeared
> when applying).
>
> Link: https://lore.kernel.org/r/[email protected]
> Fixes: 385fad1303af ("dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2022-07-25 19:41:21

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: soc: qcom: smd-rpm: extend example

On Sat, 23 Jul 2022 10:23:58 +0200, Krzysztof Kozlowski wrote:
> Replace existing limited example with proper code for Qualcomm Resource
> Power Manager (RPM) over SMD based on MSM8916. This also fixes the
> example's indentation.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/soc/qcom/qcom,smd-rpm.yaml | 33 +++++++++++++++----
> 1 file changed, 27 insertions(+), 6 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2022-07-25 21:27:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: smd: reference SMD edge schema

On 25/07/2022 21:17, Rob Herring wrote:
> On Sat, 23 Jul 2022 10:23:57 +0200, Krzysztof Kozlowski wrote:
>> The child node of smd is an SMD edge representing remote subsystem.
>> Bring back missing reference from previously sent patch (disappeared
>> when applying).
>>
>> Link: https://lore.kernel.org/r/[email protected]
>> Fixes: 385fad1303af ("dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge")
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Acked-by: Rob Herring <[email protected]>


Bjorn,

Can you take it for v5.20 via remote-proc?

Best regards,
Krzysztof

2022-08-10 16:13:27

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: smd: reference SMD edge schema

On Sat, 23 Jul 2022 10:23:57 +0200, Krzysztof Kozlowski wrote:
> The child node of smd is an SMD edge representing remote subsystem.
> Bring back missing reference from previously sent patch (disappeared
> when applying).
>
>

Applied, thanks!

[1/2] dt-bindings: soc: qcom: smd: reference SMD edge schema
commit: 568f83ffe69ba38cc10f36417d6cbb6eee4dc802
[2/2] dt-bindings: soc: qcom: smd-rpm: extend example
commit: 56e07c0c9e4a4b59a47a848b021a42cf203c982c

Best regards,
--
Bjorn Andersson <[email protected]>